Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed axis labels being cut off in interactive histograms #617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

k-luka
Copy link

@k-luka k-luka commented Oct 4, 2024

Issue:
Axis labels were being cut off in histograms when using %matplotlib notebook. This affected the readability of the plots.

Fix:
Added plt.tight_layout() to the draw_hist function in tables.py to ensure the layout is automatically adjusted to prevent labels from being cut off.

Testing:
Tested the hist method using both %matplotlib notebook and %matplotlib inline backends to confirm that the issue is resolved without introducing any side effects.

Related Issues:
Make Plots Compatible with %matplotlib notebook #538

@k-luka k-luka changed the title Fix axis labels being cut off in interactive histograms Fixed axis labels being cut off in interactive histograms Oct 4, 2024
@adnanhemani
Copy link
Member

Hi @k-luka - thanks for this. Unfortunately, here are a lot of formatting changes (which I'd highly prefer not to have, to be honest), so it's hard to review what changes exactly you've made. Additionally, I need a screenshot proof of your testing of this (and ideally, a change in the test notebook for plots that show this case).

Given both of these, it will take a longer time than I'd like to spend to review this - so I'd like to see both of these fixed before I can dedicate time to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants