Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrote test for column_index and num_columns functions in tables.py #596

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

BurakCakan
Copy link
Contributor

[x] Wrote test for feature
(I didn't see any example of addition of test pr added into the CHANGELOG, so I didn't also add)

Changes proposed:
I added two tests for column_index and num_columns functions in datascience/tables.py file.

@coveralls
Copy link

coveralls commented Aug 21, 2023

Coverage Status

coverage: 93.455%. remained the same when pulling 19f27cb on BurakCakan:feature/burak_table_tests into ec3ebcd on data-8:master.

Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you please remove the .history folder. When you do that, this looks good to merge!

@BurakCakan
Copy link
Contributor Author

Hi, can you please remove the .history folder. When you do that, this looks good to merge!

Hi, I deleted .history folder and just sent a new version push

Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnanhemani adnanhemani merged commit ca8a823 into data-8:master Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants