chore: Merge pull request #4 from dasmeta/DMVP-2829-move-s3-into-own-…

…repo

DMVP-2829: move s3 into own repo

README.md

@@ -103,7 +103,7 @@ module "my_bucket" {
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| <a name="input_acl"></a> [acl](#input\_acl) | The acl config for bucket, NOTE: 'acl' conflicts with 'grant' and 'owner'. | `string` | `null` | no |
+| <a name="input_acl"></a> [acl](#input\_acl) | The acl config for bucket, NOTE: 'acl' conflicts with 'grant' and 'owner'. | `string` | `"private"` | no |
 | <a name="input_block_public_acls"></a> [block\_public\_acls](#input\_block\_public\_acls) | Whether Amazon S3 should block public ACLs for this bucket. | `bool` | `false` | no |
 | <a name="input_block_public_policy"></a> [block\_public\_policy](#input\_block\_public\_policy) | Whether Amazon S3 should block public bucket policies for this bucket. | `bool` | `false` | no |
 | <a name="input_bucket_files"></a> [bucket\_files](#input\_bucket\_files) | Initial content for bucket, use acl and pattern params if you need more control. | <pre>object({<br>    path = string<br>  })</pre> | <pre>{<br>  "path": ""<br>}</pre> | no |

tests/private/1-example.tf

@@ -3,3 +3,10 @@ module "private" {
 
   name = "dasmeta-dev-private"
 }
+
+module "private-explicitly" {
+  source = "../.."
+
+  name = "dasmeta-dev-private-explicitly"
+  acl  = "private"
+}

tests/private/README.md

@@ -14,6 +14,7 @@ No providers.
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_private"></a> [private](#module\_private) | ../.. | n/a |
+| <a name="module_private-explicitly"></a> [private-explicitly](#module\_private-explicitly) | ../.. | n/a |
 
 ## Resources
 

tests/public/1-example.tf

@@ -4,3 +4,10 @@ module "public" {
   name = "dasmeta-dev-public-1"
   acl  = "public"
 }
+
+module "public-read" {
+  source = "../.."
+
+  name = "dasmeta-dev-public-read-1"
+  acl  = "public-read"
+}

tests/public/README.md

@@ -14,6 +14,7 @@ No providers.
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_public"></a> [public](#module\_public) | ../.. | n/a |
+| <a name="module_public-read"></a> [public-read](#module\_public-read) | ../.. | n/a |
 
 ## Resources
 

variables.tf

@@ -5,7 +5,7 @@ variable "name" {
 
 variable "acl" {
   type        = string
-  default     = null # "private"
+  default     = "private"
   description = "The acl config for bucket, NOTE: 'acl' conflicts with 'grant' and 'owner'."
 }