DMVP-3094: Adot log retention

[aghamyan44]

No description provided.

[github-actions]

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

[what-the-diff]

PR Summary

• Updated metrics export system in README files
  The README and variable setting files have been updated to reflect the change in the metrics export system from "cloudwatch" to "adot".

• Requirement Updates for AWS Provider
  The required version of the AWS provider has been raised from ">= 3.41" to "4.67.0" in the spot-instance/README.md file.

• adot_config Variable Type Improvement
  The adot_config variable type has been improved from any type to a more specific object with properties detailed (accept_namespace_regex, additional_metrics, log_group_name, log_retention, helm_values). This should make our code more robust and easier to understand.

• Log Retention Variable Introduced in helm_release resource
  A new log_retention variable has been added to the helm_release resource. This addition allows us to specify the retention period for logs.

• Inclusion of Log Retention in adotCollector
  The adotCollector section now includes the log_retention variable. This ensures that our retention policies are upheld.

• Security Role Updates
  The AWS security role file (adot/role.tf) has been updated to include a new AWS IAM policy resource and a modification of the existing aws_iam_role_policy_attachment resource to include the new policy, enhancing the security setup.

• Default Value Change for autoscaler_image_patch
  The default value of the autoscaler_image_patchvariable has been changed from 0 to 1 in both the autoscaler/README.md and autoscaler/variables.tf files. This change is expected to increase the efficiency of our autoscaling operation.

• metrics_exporter Default Value Update
  The default value of the metrics_exporter variable was updated from "cloudwatch" to "adot", aligning it with the changes made in the README files. The adot_config variable type was also updated to match the changes in the adot/variables.tf file, providing consistency across all variable definitions.

[github-actions]

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

[github-actions]

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

[github-actions]

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

[aramkarapetian]

LGTM

[github-actions]

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

[aramkarapetian]

LGTM

[github-actions]

🎉 This PR is included in version 2.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed