Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMVP-6378: to have nginx ingress load balancer external/internet-facing by default #114

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

mrdntgrn
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Jan 10, 2025

PR Summary

  • Enhanced Documentation
    Updated the README.md to provide additional instructions for setting up Karpenter, particularly for VPCs created externally and usage of spot instances.

  • Improved Configuration Flexibility for Nginix Ingress Controller
    The nginx_ingress_controller_config input variable has been expanded to include a new key, configs. This allows for custom configurations and scalable adaptations based on specific project requirements.

  • Updated Default Version for Nginx Ingress Controller
    The default chart_version for the Nginx Ingress Controller is now 4.12.0, upgraded from 4.11.3, so users can now benefit from the latest fixes, improvements and added features in the newer version.

  • Dynamic Default Configuration Application in Helm Release Resource
    The Helm release resource has been amended to use merged default configurations dynamically. This is achieved through a new custom_default_configs_merged module, enhancing code efficiency and readability.

  • Inclusion of Annotations and Metrics in Nginix Ingress Controller Configuration
    Added logic to define annotations and metrics within the Nginx Ingress Controller configuration to provide better monitoring and control.

@mrdntgrn mrdntgrn merged commit c88eb7f into main Jan 10, 2025
9 checks passed
@mrdntgrn mrdntgrn deleted the fix/DMVP-6378-ingress-nginx-internet-facing branch January 10, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants