Expose details in worker timeout exceptions #9092
Conversation
so that calling code can have more precise logic about how to handle the error
nocnokneo
force-pushed
the
custom-worker-timeout-exception
branch
from
c3ee5de to
097ed4a
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 14m 31s ⏱️ + 6m 51s For more details on these failures and errors, see this check. Results for commit 097ed4a. ± Comparison against base commit 9c8cd91. |
| @property | ||
| def available_workers(self) -> int: | ||
| """Number of workers that are available.""" | ||
| return self.args[0] |
There was a problem hiding this comment.
I've not seen exceptions implemented this way before with properties pointing to arg indices. There's a code smell here I can't quite put my finger on, it feels brittle.
Why not set the attributes explicitly during the __init__?
There was a problem hiding this comment.
hah, I totally agree! I had originally set the attributes in __init__ but noticed that other custom exceptions in this project were following this (odd) pattern so just went with it for consistency. Happy to revert back to my original approach.
There was a problem hiding this comment.
One example of the existing pattern:
distributed/distributed/scheduler.py
Line 9302 in 9c8cd91
in a structured way so that calling code can have more precise logic about how to handle the error
Closes #xxxx
added/ passedpre-commit run --all-files