Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust timeouts in jupyter cli test #8925

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Nov 6, 2024

This test is failing pretty constantly. #8848 made things worse so I suggest increasing the timeout for this. I also put in the default ports fixture since the test requires the port 8787

If that doesn't work I'll likely skip the test since the signal it adds is only marginal and it is failing all over CI (but running locally)

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ±    0      25 suites  ±0   10h 14m 14s ⏱️ + 46m 35s
 4 128 tests  -     2   4 015 ✅ +    4    110 💤  -  2  3 ❌  - 4 
47 668 runs  +1 408  45 551 ✅ +1 370  2 114 💤 +44  3 ❌  - 6 

For more details on these failures, see this check.

Results for commit 0b58451. ± Comparison against base commit 7d43e2f.

This pull request removes 2 tests.
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---nanny]
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---no-nanny]

@fjetter
Copy link
Member Author

fjetter commented Nov 6, 2024

Well, far from conclusive but this CI job is not having a test failure for this jupyter CLI test. Merging

@fjetter fjetter merged commit 559f546 into dask:main Nov 6, 2024
28 of 33 checks passed
@fjetter fjetter deleted the skip_jupyter_cli_test branch November 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant