Remove redundant methods in P2PBarrierTask #8924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ±0 25 suites ±0 10h 15m 12s ⏱️ - 3m 37s For more details on these failures, see this check. Results for commit 0a8082c. ± Comparison against base commit c38c509. ♻️ This comment has been updated with latest results. |
fjetter
force-pushed
the
improve_subclass_barrier_task
branch
from
1ff8eb8
to
4c78021
Compare
6 tasks
fjetter
force-pushed
the
improve_subclass_barrier_task
branch
from
aada6e4
to
53e7e18
Compare
jrbourbeau
reviewed
Nov 8, 2024
There was a problem hiding this comment.
@fjetter @hendrikmakait It looks like CI (both tests and linting) are very broken here
E AttributeError: 'P2PBarrierTask' object has no attribute 'spec'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are fragile and no longer necessary with dask/dask#11496