Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recursion in task spec #8920

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Remove recursion in task spec #8920

wants to merge 9 commits into from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Oct 31, 2024 •
edited
Loading

See

The most important PR to review is the dask/dask one.

@fjetter fjetter mentioned this pull request Oct 31, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ±0      25 suites  ±0   10h 23m 10s ⏱️ + 2m 41s
 4 130 tests ±0   4 016 ✅ ±0    110 💤 ±0  4 ❌ ±0 
47 692 runs  ±0  45 565 ✅  - 1  2 122 💤 +1  5 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4d6826a. ± Comparison against base commit d7eff77.

♻️ This comment has been updated with latest results.

hendrikmakait
hendrikmakait requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2P currently imports _inline_recursively which has been removed. (See CI failure: distributed/shuffle/_core.py:28: error: Module "dask._task_spec" has no attribute "_inline_recursively"; maybe "_call_recursively"? [attr-defined])

EDIT: Ignore the above, we've run into a review race condition.

@fjetter
Copy link
Member Author

fjetter commented Nov 4, 2024

EDIT: Ignore the above, we've run into a review race condition.

Yeah, I'm still working on CI. The gist of the changes will very likely remain the same so I encourage a review regardless of bad CI

@fjetter fjetter force-pushed the task_spec_remove_recursion branch 3 times, most recently from 877fb11 to e5d5d24 Compare November 14, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait requested changes

@phofl phofl phofl approved these changes

@jacobtomlinson jacobtomlinson Awaiting requested review from jacobtomlinson jacobtomlinson is a code owner

@quasiben quasiben Awaiting requested review from quasiben quasiben is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fjetter @hendrikmakait @phofl