-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add support for Python 3.13 #8904
Open
phofl
wants to merge
19
commits into
dask:main
Choose a base branch
from
phofl:313
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−7
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2b51695
Add ci job for python 3.13
phofl 7c5d73f
Add ci job for python 3.13
phofl 460407d
Update
phofl ef637b8
Turn VERIFY_X509_STRICT tls flag off
jrbourbeau 13ebbc2
Add 3.13 classifier
jrbourbeau 6c42305
Add pyarrow back
jrbourbeau 7ecbe0d
Add dask-expr
jrbourbeau ba3bb98
Remove nightly pyarrow from normal testing
jrbourbeau 2e92412
Fix test_https_support
jrbourbeau 4271bcd
Merge branch 'main' of https://github.com/dask/distributed into 313
jrbourbeau ef558f5
Run CI
jrbourbeau 0fd7889
Merge branch 'main' of https://github.com/dask/distributed into 313
jrbourbeau d49e34a
Temporarily skip test_upload_file_zip on Python 3.13+
jrbourbeau bbb96f1
Merge branch 'main' of https://github.com/dask/distributed into 313
jrbourbeau 15c691d
Remove change?
jrbourbeau bf392cb
Maybe?
jrbourbeau 7e28780
Add skip back
jrbourbeau e053c0e
Fix next_resync Windows test failure
jrbourbeau e3819b6
One more
jrbourbeau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
name: dask-distributed-313 | ||
channels: | ||
- conda-forge | ||
dependencies: | ||
- python=3.13 | ||
- packaging | ||
- pip | ||
- asyncssh | ||
- bokeh>3 | ||
- click | ||
- cloudpickle | ||
- coverage | ||
- dask # overridden by git tip below | ||
- filesystem-spec # overridden by git tip below | ||
- gilknocker | ||
- h5py | ||
- ipykernel | ||
- ipywidgets | ||
- jinja2 | ||
- jupyter-server-proxy | ||
- jupyterlab | ||
- locket | ||
- msgpack-python | ||
- netcdf4 | ||
- paramiko | ||
- pre-commit | ||
- prometheus_client | ||
- psutil | ||
- pyarrow | ||
- pytest | ||
- pytest-cov | ||
- pytest-faulthandler | ||
- pytest-repeat | ||
- pytest-rerunfailures | ||
- pytest-timeout | ||
- requests | ||
- s3fs # overridden by git tip below | ||
- scikit-learn | ||
- scipy | ||
- sortedcollections | ||
- tblib | ||
- toolz | ||
- tornado | ||
- zict # overridden by git tip below | ||
- zstandard | ||
# Temporary fix for https://github.com/pypa/setuptools/issues/4496 | ||
- setuptools < 71 | ||
- pip: | ||
- git+https://github.com/dask/dask | ||
- git+https://github.com/dask/dask-expr | ||
- git+https://github.com/dask/zict | ||
# Revert after https://github.com/dask/distributed/issues/8614 is fixed | ||
# - git+https://github.com/dask/s3fs | ||
# - git+https://github.com/fsspec/filesystem_spec | ||
- keras |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone ahead and turned this new
VERIFY_X509_STRICT
flag off here (it was previously off by default in older versions of Python but was flipped on by default in Python 3.13). This seems not ideal, but also not that bad given that's what we've always done prior to Python 3.13. @jacobtomlinson (or anyone else) let me know if you have a better suggestion, I'm not verify familiar with our TLS security code paths.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using https://github.com/python-trio/trustme to generate the certificates used for testing on the fly would get this to pass (as it sets the appropriate flags on the certificates and generally keeps these flags up to date)
of course, distributed users would also need to configure their certificates to meet these stronger security standards