Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump alpine to 3.21, golang to 1.23.6 #1042

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Feb 5, 2025

Issue being fixed or feature implemented

Go >= 1.23.5 is needed by #1041

Unfortunately, it's not supported by Alpine 3.19, so we update to the newest one (3.21).

What was done?

Updated Golang to 1.23.6
Updated Alpine to 3.21

How Has This Been Tested?

GHA

Breaking Changes

New version of go is required to build

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores

    • Upgraded the Go environment from version 1.23.2 to 1.23.6 across CI pipelines, testing workflows, and Docker builds to enhance stability and performance.
  • Documentation

    • Updated the minimum Go version requirement.
    • Enhanced tutorials with detailed, step-by-step guidance for setting up a new project, integrating a database, and testing transactions.

@lklimek lklimek added this to the v1.5 milestone Feb 5, 2025
Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

This pull request updates the Go version from 1.23.2 to 1.23.6 across multiple configuration and documentation files. The changes span GitHub Actions workflows, Dockerfiles, module definitions, and user guides. Additionally, the tutorials have been expanded to include detailed instructions for building a Tendermint Core key-value store application with new method implementations. No modifications to the underlying logic or control flow were introduced apart from these version updates and tutorial enhancements.

Changes

File(s) Change Summary
.github/actions/bls/action.yml, .github/workflows/{build.yml, check-generated.yml, e2e.yml, lint.yml, release.yml, tests.yml} Updated Go version from 1.23.2 to 1.23.6 in GitHub Actions workflows.
DOCKER/…/Dockerfile, test/e2e/docker/Dockerfile Updated ARG GOLANG_VERSION from 1.23.2 to 1.23.6 in Dockerfiles.
README.md, go.mod, test/fuzz/README.md Updated Go version requirements from 1.23.2 to 1.23.6.
docs/tutorials/{go-built-in.md, go.md} Expanded tutorial content for building a Tendermint Core key-value store application, including new methods and additional configuration instructions, with the Go version updated to 1.23.6.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Tendermint
    participant KVStoreApp
    participant Database

    Client->>Tendermint: Send Transaction
    Tendermint->>KVStoreApp: CheckTx
    KVStoreApp-->>Tendermint: Validate Transaction
    Tendermint->>KVStoreApp: DeliverTx
    KVStoreApp->>Database: Update State
    KVStoreApp-->>Tendermint: Deliver Response
    Tendermint->>KVStoreApp: Commit
    KVStoreApp->>Database: Commit Changes
    KVStoreApp-->>Tendermint: Commit Response
    Client->>Tendermint: Query State
    Tendermint->>KVStoreApp: Query
    KVStoreApp-->>Tendermint: Return State
Loading

Possibly related PRs

Suggested reviewers

  • QuantumExplorer
  • shumkov

Poem

Oh, how I hop through lines of code,
Skipping from version to version with a joyful mode.
From 1.23.2 to 1.23.6 I leap,
In workflows and docs, treasures I keep.
A rabbit’s tune in ASCII delight,
Celebrating changes that now shine so bright!
🐇✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37bb669 and a6604aa.

📒 Files selected for processing (2)
  • DOCKER/Dockerfile (1 hunks)
  • test/e2e/docker/Dockerfile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • test/e2e/docker/Dockerfile
  • DOCKER/Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: tests (05)
  • GitHub Check: tests (04)
  • GitHub Check: tests (03)
  • GitHub Check: tests (02)
  • GitHub Check: e2e-test (rotate)
  • GitHub Check: tests (01)
  • GitHub Check: e2e-test (dashcore)
  • GitHub Check: Build (amd64, linux)
  • GitHub Check: Super linter
  • GitHub Check: golangci-lint
  • GitHub Check: tests (00)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lklimek lklimek changed the title build(deps): bump golang to 1.23.6 build(deps): bump alpine to 3.21, golang to 1.23.6 Feb 5, 2025
@lklimek lklimek merged commit e000dc6 into v1.5-dev Feb 7, 2025
19 checks passed
@lklimek lklimek deleted the deps/go-1.23.6 branch February 7, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants