Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): update changelog and bump version to 1.8.0-dev.2 #2404

Merged
merged 2 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,33 @@
## [1.8.0-dev.2](https://github.com/dashpay/platform/compare/v1.8.0-dev.1...v1.8.0-dev.2) (2024-12-19)

### ⚠ BREAKING CHANGES

* On epoch 13, masternode vote state transition validation logic will be changed. Nodes which aren't upgraded to this version will halt (#2397)
* Rust 1.83 is required to build the project (#2398)
Comment on lines +5 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Based on the PR description and code search results, I can now provide the final response:

Critical breaking change: Masternode vote validation fix requires node upgrade by epoch 13

The masternode voting system was broken in protocol version 6 due to incorrect nonce validation against owner identity instead of voting identity. This emergency hard fork fixes the validation by using the correct voting identity nonce starting from epoch 13. All nodes must upgrade before epoch 13 to avoid halting.

🔗 Analysis chain

Critical breaking change: Masternode vote validation changes require node upgrades

Nodes that are not upgraded to this version will halt at epoch 13 due to changes in masternode vote state transition validation logic.


Let me check the referenced PR for more details about this breaking change.


Let me check the code changes related to this breaking change.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any references to the breaking change in code
rg -A 5 "masternode vote state transition validation"

Length of output: 851


Script:

#!/bin/bash
# Check PR #2397 for more details about the breaking change
gh pr view 2397 --json title,body,commits

# Look for any code changes related to masternode voting validation
rg -A 5 "masternode.*vote.*validation"

Length of output: 65620


Script:

#!/bin/bash
# Look for code changes related to masternode voting validation
rg -A 5 "voting.*identity.*nonce"
rg -A 5 "owner.*identity.*nonce"

Length of output: 4259


### Bug Fixes

* **dashmate:** local network starting issues ([#2394](https://github.com/dashpay/platform/issues/2394))
* **dashmate:** some group commands fail with mtime not found ([#2400](https://github.com/dashpay/platform/issues/2400))
* emergency hard fork to fix masternode voting ([#2397](https://github.com/dashpay/platform/issues/2397))


### Performance Improvements

* **dpp:** reduce JS binding size by 3x ([#2396](https://github.com/dashpay/platform/issues/2396))


### Build System

* bump wasm-bindgen to 0.2.99 ([#2395](https://github.com/dashpay/platform/issues/2395))
* update rust to 1.83 ([#2393](https://github.com/dashpay/platform/issues/2393))


### Code Refactoring

* **dpp:** using deprecated param to init wasm module ([#2399](https://github.com/dashpay/platform/issues/2399))


### [1.7.1](https://github.com/dashpay/platform/compare/v1.7.0...v1.7.1) (2024-12-19)

### ⚠ BREAKING CHANGES
Expand Down
52 changes: 26 additions & 26 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dashevo/platform",
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"private": true,
"scripts": {
"setup": "yarn install && yarn run build && yarn run configure",
Expand Down
2 changes: 1 addition & 1 deletion packages/bench-suite/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@dashevo/bench-suite",
"private": true,
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"description": "Dash Platform benchmark tool",
"scripts": {
"bench": "node ./bin/bench.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/check-features/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "check-features"
version = "1.8.0-dev.1"
version = "1.8.0-dev.2"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Expand Down
2 changes: 1 addition & 1 deletion packages/dapi-grpc/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "dapi-grpc"
description = "GRPC client for Dash Platform"
version = "1.8.0-dev.1"
version = "1.8.0-dev.2"
authors = [
"Samuel Westrich <[email protected]>",
"Igor Markin <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion packages/dapi-grpc/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dashevo/dapi-grpc",
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"description": "DAPI GRPC definition file and generated clients",
"browser": "browser.js",
"main": "node.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/dapi/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@dashevo/dapi",
"private": true,
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"description": "A decentralized API for the Dash network",
"scripts": {
"api": "node scripts/api.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/dash-spv/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dashevo/dash-spv",
"version": "2.8.0-dev.1",
"version": "2.8.0-dev.2",
"description": "Repository containing SPV functions used by @dashevo",
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/dashmate/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dashmate",
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"description": "Distribution package for Dash node installation",
"scripts": {
"lint": "eslint .",
Expand Down
2 changes: 1 addition & 1 deletion packages/dashpay-contract/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "dashpay-contract"
description = "DashPay data contract schema and tools"
version = "1.8.0-dev.1"
version = "1.8.0-dev.2"
edition = "2021"
rust-version.workspace = true
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion packages/dashpay-contract/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dashevo/dashpay-contract",
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"description": "Reference contract of the DashPay DPA on Dash Evolution",
"scripts": {
"lint": "eslint .",
Expand Down
2 changes: 1 addition & 1 deletion packages/data-contracts/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "data-contracts"
description = "Dash Platform system data contracts"
version = "1.8.0-dev.1"
version = "1.8.0-dev.2"
edition = "2021"
rust-version.workspace = true
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion packages/dpns-contract/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "dpns-contract"
description = "DPNS data contract schema and tools"
version = "1.8.0-dev.1"
version = "1.8.0-dev.2"
edition = "2021"
rust-version.workspace = true
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion packages/dpns-contract/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dashevo/dpns-contract",
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"description": "A contract and helper scripts for DPNS DApp",
"scripts": {
"lint": "eslint .",
Expand Down
2 changes: 1 addition & 1 deletion packages/feature-flags-contract/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "feature-flags-contract"
description = "Feature flags data contract schema and tools"
version = "1.8.0-dev.1"
version = "1.8.0-dev.2"
edition = "2021"
rust-version.workspace = true
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion packages/feature-flags-contract/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dashevo/feature-flags-contract",
"version": "1.8.0-dev.1",
"version": "1.8.0-dev.2",
"description": "Data Contract to store Dash Platform feature flags",
"scripts": {
"build": "",
Expand Down
Loading
Loading