fix(drive): documents have mixed owner ids (#283)

dashpay · Mar 8, 2022 · 26fcca7 · 26fcca7
1 parent a5fc1c1
commit 26fcca7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js b/packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
@@ -137,19 +137,21 @@ function synchronizeMasternodeIdentitiesFactory(
     }
 
     // Process masternode reward contract updates
-    if (documentsToCreate.length > 0 || documentsToDelete > 0) {
-      const chunkedDocuments = splitDocumentsIntoChunks({
-        create: documentsToCreate,
-        delete: documentsToDelete,
+
+    for (const document of documentsToCreate) {
+      const documentsBatchTransition = transactionalDpp.document.createStateTransition({
+        create: [document],
       });
 
-      for (const documentsChunk of chunkedDocuments) {
-        const documentsBatchTransition = transactionalDpp.document.createStateTransition(
-          documentsChunk,
-        );
+      await transactionalDpp.stateTransition.apply(documentsBatchTransition);
+    }
 
-        await transactionalDpp.stateTransition.apply(documentsBatchTransition);
-      }
+    for (const document of documentsToDelete) {
+      const documentsBatchTransition = transactionalDpp.document.createStateTransition({
+        delete: [document],
+      });
+
+      await transactionalDpp.stateTransition.apply(documentsBatchTransition);
     }
   }
 

diff --git a/...ges/js-drive/test/unit/identity/masternode/synchronizeMasternodeIdentitiesFactory.spec.js b/...ges/js-drive/test/unit/identity/masternode/synchronizeMasternodeIdentitiesFactory.spec.js
@@ -198,7 +198,7 @@ describe('synchronizeMasternodeIdentitiesFactory', () => {
       { mnList: smlFixture.concat(newSmlFixture) },
     );
 
-    const newIdentities = { create: [documentsFixture[0]], delete: [] };
+    const newIdentities = { create: [documentsFixture[0]] };
 
     handleNewMasternodeMock.returns(newIdentities);
     splitDocumentsIntoChunksMock.returns([newIdentities]);
@@ -222,7 +222,6 @@ describe('synchronizeMasternodeIdentitiesFactory', () => {
     expect(handleUpdatedPubKeyOperatorMock).to.be.not.called();
     expect(stateRepositoryMock.fetchDocuments).to.be.not.called();
 
-    expect(splitDocumentsIntoChunksMock).to.be.calledWithExactly(newIdentities);
     expect(transactionalDppMock.document.createStateTransition)
       .to.be.calledWithExactly(newIdentities);
     expect(transactionalDppMock.stateTransition.apply).to.be.calledWithExactly(