Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update multisig example #348

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Apr 8, 2024

Uses Dash addresses now and switched to signrawtransactionwithkey since signrawtransaction was deprecated. Also switched to using getaddressinfo instead of validateaddress. The actual txs can be seen at https://testnet-insight.dashevo.org/insight/address/8gQdvLw7pF7jd8mjGU3nRNESdWi9gkHRZy.

Preview build: https://dash-docs--348.org.readthedocs.build/en/348/docs/user/wallets/dashcore/advanced.html#multisignature

Uses Dash addresses now and switched to signrawtransactionwithkey since signrawtransaction was deprecated
@thephez thephez requested review from UdjinM6 and strophy April 8, 2024 18:02
Copy link
Collaborator

@strophy strophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thephez thephez merged commit 587fb26 into dashpay:20.1.0 Apr 9, 2024
1 check passed
@thephez thephez deleted the v20-multsig-example-update branch April 9, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants