-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update core install verification #335
Conversation
Last release signed by codablock was v0.15 in early 2020
131ccb1
to
c821ce0
Compare
I think it would be valuable to create a signature on this key to make the output messages better. On macOS / linux this would look like
(tries to quick sign key; if we can't that probably means we don't have a private key, so generate one then re-sign) On windows this can be done in kleopatra via the "certify key" option if you certify the validation looks like
if you don't certify it looks like this; more scary as it kinda should be
|
I'm conflicted on this. More steps = less likely that someone is going to actually do it. I also don't like auto-creating a key for someone to avoid that message. Provided someone actually looks at the fingerprint, certifying doesn't actually make anything safer. The Windows instructions in particular need more work anyway (they lag because none of us actually use Windows). I'd prefer to merge this small cleanup PR and leave the rest for a separate thing. My Kleopatra updates are actually from Linux because I figured they're at least more accurate than the outdated ones that were there before. Edit: I added a note to Linux/Mac about signing the key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Remove some outdated references and update some screenshots
Preview build: