-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dip31): platform proof of service #157
Open
thephez
wants to merge
19
commits into
dashpay:master
Choose a base branch
from
thephez:dip-platform-pose
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+125
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephez
requested review from
shumkov,
ogabrielides,
knst,
lklimek,
UdjinM6,
HashEngineering,
PastaPastaPasta and
QuantumExplorer
September 24, 2024 14:21
ogabrielides
requested changes
Oct 3, 2024
shumkov
requested changes
Oct 19, 2024
thephez
force-pushed
the
dip-platform-pose
branch
from
October 23, 2024 14:25
42511dc
to
87fe980
Compare
thephez
commented
Dec 2, 2024
UdjinM6
reviewed
Dec 2, 2024
Co-authored-by: UdjinM6 <[email protected]>
Co-authored-by: PastaPastaPasta <[email protected]>
thephez
commented
Dec 5, 2024
Co-authored-by: UdjinM6 <[email protected]>
thephez
requested review from
PastaPastaPasta,
UdjinM6,
ogabrielides and
shumkov
December 5, 2024 19:22
UdjinM6
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ogabrielides @PastaPastaPasta @shumkov please re-review when possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that evonodes provide service on Dash Platform and that non-functioning evonodes do not participate in the Platform validator set, Platform needs a way to exclude faulty evonodes from future Platform validator sets / quorums. Since these nodes are not properly providing service, they should be proof-of-service (PoSe) banned. This DIP outlines a method for Platform to securely notify Core that a node should be banned.