Merge pull request #5156 from PastaPastaPasta/v18.2.1-backports

[v18.2.x] v18.2.1 backports, release notes

.github/workflows/handle_potential_conflicts.py

@@ -1,3 +1,6 @@
+# Copyright (c) 2022 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 import sys
 import requests
 

ci/dash/build-docker.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2021-2022 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 export LC_ALL=C
 

ci/dash/build_depends.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2021 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 # This script is executed inside the builder image
 

ci/dash/build_src.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2021-2022 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 # This script is executed inside the builder image
 

ci/dash/matrix.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2019-2022 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 # This script is meant to be sourced into the actual build script. It contains the build matrix and will set all
 # necessary environment variables for the request build target

ci/dash/push-docker.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2021 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 export LC_ALL=C
 

ci/dash/test_integrationtests.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2018-2022 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 # This script is executed inside the builder image
 

ci/dash/test_unittests.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2021-2022 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 # This script is executed inside the builder image
 

configure.ac

@@ -1,10 +1,10 @@
 AC_PREREQ([2.69])
 define(_CLIENT_VERSION_MAJOR, 18)
 define(_CLIENT_VERSION_MINOR, 2)
-define(_CLIENT_VERSION_BUILD, 0)
+define(_CLIENT_VERSION_BUILD, 1)
 define(_CLIENT_VERSION_RC, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)
-define(_COPYRIGHT_YEAR, 2022)
+define(_COPYRIGHT_YEAR, 2023)
 define(_COPYRIGHT_HOLDERS,[The %s developers])
 define(_COPYRIGHT_HOLDERS_SUBSTITUTION,[[Dash Core]])
 AC_INIT([Dash Core],m4_join([.], _CLIENT_VERSION_MAJOR, _CLIENT_VERSION_MINOR, _CLIENT_VERSION_BUILD)m4_if(_CLIENT_VERSION_RC, [0], [], [rc]_CLIENT_VERSION_RC),[https://github.com/dashpay/dash/issues],[dashcore],[https://dash.org/])

contrib/auto_gdb/common_helpers.py

@@ -1,4 +1,7 @@
 #!/usr/bin/env python3
+# Copyright (c) 2018-2020 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 
 import sys

contrib/auto_gdb/dash_dbg.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2018-2020 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 # use testnet settings,  if you need mainnet,  use ~/.dashcore/dashd.pid file instead
 export LC_ALL=C
 

contrib/auto_gdb/log_size.py

@@ -1,4 +1,7 @@
 #!/usr/bin/env python3
+# Copyright (c) 2018-2021 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 
 try:

contrib/auto_gdb/simple_class_obj.py

@@ -1,4 +1,7 @@
 #!/usr/bin/env python3
+# Copyright (c) 2018-2021 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 
 import sys

contrib/auto_gdb/stl_containers.py

@@ -1,4 +1,7 @@
 #!/usr/bin/env python3
+# Copyright (c) 2018-2020 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 
 try:

contrib/auto_gdb/used_size.py

@@ -1,4 +1,7 @@
 #!/usr/bin/env python3
+# Copyright (c) 2018-2021 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 #
 
 try:

contrib/containers/deploy/docker-entrypoint.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright (c) 2021 The Dash Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 export LC_ALL=C
 set -e

contrib/devtools/copyright_header.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 # Copyright (c) 2016-2019 The Bitcoin Core developers
-# Copyright (c) 2019-2021 The Dash Core developers
+# Copyright (c) 2019-2023 The Dash Core developers
 # Distributed under the MIT software license, see the accompanying
 # file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -17,10 +17,16 @@
 
 EXCLUDE = [
     # auto generated:
-    'src/qt/bitcoinstrings.cpp',
+    'src/qt/dashstrings.cpp',
     'src/chainparamsseeds.h',
     # other external copyrights:
+    'src/bip39.cpp',
+    'src/bip39.h',
+    'src/bip39_english.h',
+    'src/crypto/*',
+    'src/ctpl_stl.h',
     'src/reverse_iterator.h',
+    'src/statsd_client.cpp',
     'src/test/fuzz/FuzzedDataProvider.h',
     'src/tinyformat.h',
     'src/bench/nanobench.h',

doc/release-notes.md

@@ -1,16 +1,19 @@
-Dash Core version v18.2.0
+Dash Core version v18.2.1
 =========================
 
 Release is now available from:
 
   <https://www.dash.org/downloads/#wallets>
 
-This is a new minor version release, bringing new features, various bugfixes
-and other improvements.
+This is a new hotfix version release, bringing various bugfixes.
 
-This release is optional for all nodes.
+Please note that v18.2.0 was revoked due to a bug; this version fixes that bug.
 
-Please report bugs using the issue tracker at github:
+This release is optional for all nodes; however, v18.2.1 is required to be
+able to use both mainnet and testnet. Currently, v18.2.0 is not working on mainnet,
+and v18.1.1 is not working on testnet; v18.2.1 will work on both networks.
+
+Please report bugs using the issue tracker at GitHub:
 
   <https://github.com/dashpay/dash/issues>
 
@@ -38,16 +41,21 @@ downgrade to an older version is only possible with a reindex
 Downgrade warning
 -----------------
 
-### Downgrade to a version < v18.2.0
+### Downgrade to a version < v18.2.1
 
-Downgrading to a version older than v18.2.0 is supported.
+Downgrading to a version older than v18.2.1 is supported.
 
 ### Downgrade to a version < v18.0.1
 
 Downgrading to a version older than v18.0.1 is not supported due to changes in
 the indexes database folder. If you need to use an older version, you must
 either reindex or re-sync the whole chain.
 
+### Downgrade of masternodes to < 18.2.1
+
+It is highly recommended not to downgrade masternodes below 18.2.1, as 18.2.1 (and 18.1.1)
+fix important bugs which may result in your masternode being PoSe banned.
+
 ### Downgrade of masternodes to < v18.0.1
 
 Starting with the 0.16 release, masternodes verify the protocol version of other
@@ -64,48 +72,26 @@ releases are minimized, however we do not guarantee there are no breaking change
 Bitcoin backports often introduce breaking changes, and are a likely source of
 breaking changes in minor releases. Patch releases should never contain breaking changes.
 
-This release **does** include breaking changes. Please read below to see if they will affect you.
-
 Notable changes
 ===============
+See #5145 and #5142; these 2 PR fix important bugs in previous versions. Specifically,
+#5145 fixes an issue where qfcommit messages can be replayed from the past, then are
+validated and propagated to other nodes. This patch prevents old qfcommits
+from being relayed. #5142 is a fix which enables this version to function both on testnet
+and mainnet.
 
 
 Remote Procedure Call (RPC) Changes
 -----------------------------------
 
 ### The new RPCs are:
-
-- `analyzepsbt` examines a PSBT and provides information about what
-  the PSBT contains and the next steps that need to be taken in order
-  to complete the transaction. For each input of a PSBT, `analyzepsbt`
-  provides information about what information is missing for that
-  input, including whether a UTXO needs to be provided, what pubkeys
-  still need to be provided, which scripts need to be provided, and
-  what signatures are still needed. Every input will also list which
-  role is needed to complete that input, and `analyzepsbt` will also
-  list the next role in general needed to complete the PSBT.
-  `analyzepsbt` will also provide the estimated fee rate and estimated
-  virtual size of the completed transaction if it has enough
-  information to do so.
-- `quorum listextended` is the cousin of `quorum list` with a more enriched reply. By using the `height` parameter, the RPC will list active quorums at a specified height (or at the tip if `height` is not specified).
-  This RPC returns the following data per quorum grouped per llmqTypes:
-    - For each `quorumHash`:
-        - `creationHeight`: Block height where its DKG started
-        - `quorumIndex`: Returned only for rotated llmqTypes
-        - `minedBlockHash`: Hash of the block containing the mined final commitment
-        - `numValidMembers`: The total of valid members.
-        - `healthRatio`: The ratio of healthy members to quorum size. Range [0.0 - 1.0].
-- `getbalances` returns an object with all balances (`mine`,
-  `untrusted_pending` and `immature`). Please refer to the RPC help of
-  `getbalances` for details. The new RPC is intended to replace
-  `getunconfirmedbalance` and the balance fields in `getwalletinfo`, as well as
-  `getbalance`. The old calls may be removed in a future version.
+None
 
 ### The removed RPCs are:
 None
 
 ### Changes in existing RPCs introduced through bitcoin backports:
-- `walletprocesspsbt` and `walletcreatefundedpsbt` now include BIP 32 derivation paths by default for public keys if we know them. This can be disabled by setting `bip32derivs` to `false`.
+None
 
 ### Dash-specific changes in existing RPCs:
 None
@@ -114,20 +100,19 @@ Please check `help <command>` for more detailed information on specific RPCs.
 
 Command-line options
 --------------------
-
+None
 
 Please check `Help -> Command-line options` in Qt wallet or `dashd --help` for
 more information.
 
 Backports from Bitcoin Core
 ---------------------------
+None
 
-This release introduces many hundreds updates from Bitcoin v0.18/v0.19/v0.20/v0.21/v22. Bitcoin changes that do not align with Dash’s product needs, such as SegWit and RBF, are excluded from our backporting. For additional detail on what’s included in Bitcoin, please refer to their release notes.
-
-v18.2.0 Change log
+v18.2.1 Change log
 ==================
 
-See detailed [set of changes](https://github.com/dashpay/dash/compare/v18.1.0...dashpay:v18.2.0).
+See detailed [set of changes](https://github.com/dashpay/dash/compare/v18.2.0...dashpay:v18.2.1).
 
 Credits
 =======
@@ -138,8 +123,6 @@ Thanks to everyone who directly contributed to this release:
 - Konstantin Akimov
 - Odysseas Gabrielides
 - PastaPastaPasta
-- strophy
-- thephez
 - UdjinM6
 
 As well as everyone that submitted issues, reviewed pull requests, helped debug the release candidates, and write DIPs that were implemented in this release.
@@ -167,6 +150,8 @@ Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
 
 These release are considered obsolete. Old release notes can be found here:
 
+- [v18.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.0.md) released Jan/01/2023
+- [v18.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.1.md) released January/08/2023
 - [v18.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.0.md) released October/09/2022
 - [v18.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.2.md) released October/09/2022
 - [v18.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.1.md) released August/17/2022