Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coinbase 2fa send error #1341

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix: coinbase 2fa send error #1341

merged 2 commits into from
Jan 13, 2025

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jan 13, 2025

Coinbase send request with 2fa fails because it uses different idem from the original, non-2fa request

Issue being fixed or feature implemented

  • Keep original idem for 2fa request
  • Some refactoring to remove Resource return value

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Jan 13, 2025
HashEngineering
HashEngineering approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HashEngineering HashEngineering merged commit 447e319 into master Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashEngineering HashEngineering HashEngineering approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @HashEngineering