feat(dashpay): improve voting feature #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: update username voting screen * feat: add keys changes * feat: add keys errors * refactor: change vote system to return a tuple * refactor: change vote queries to use get_vote_polls * fix: improve Username Voting screen and voting * feature: add delete masternode key functionality (disabled) * fix: use withContext(Dispatchers.IO) * fix: add voting keys fixes * fix: fix vote click bug * fix: add vote key again * fix: prevent counting one vote as many * chore: log the wrong vote differently * fix: correct duplicate key detection * fix: fix request process state * fix: add tools:text for Results on * chore: remove commented code * fix: simplify Username Request vote button styles * fix: delete vote fix * feat: add OneVoteLeftDialog * feat: add blue lightning bolt next to Quick Voting * feat: add countVotes * fix: spacing and text on OneVoteLeftDialogFragment * feat: add new text for Quick Voting * feat: add isQuickVoting for BroadcastUsernameVotes* classes * feat: isApproved is based on the last vote * fix: update voteForAll functiom * fix: update voteForAll function * feat: add quick voting support to UsernameRequestsFragment * feat: improve username search in UsernameRequestsFragment * feat: improve username search in UsernameRequestsFragment * fix: keep track of normalized and regular labels * fix: some bugs resulting from removing mocking
…1328) * fix: allow space for 2 lines of title on Username Voting layout * fix: improve tracking progress of votes from worker * fix: properly show "link included" * refactor: some types changed in dash-sdk-kotlin * fix: minor changes * chore: remove comment * fix: make prepopulateList conform to all rules * fix: maintain expanded status of a username request group * fix: More Fragment Join button size
* feat: show delete button and increase its padding * feat: show delete button only for imported masternode keys * chore: add license ot AddVotingKeysFragment * fix: make the delete MN button larger
…feature-voting-improvements
* feat: add voting period ends improvements * feat: use thumbs up/down logos instead * fix: crash on empty list * fix: update sorting to match user selection * feat: improve sorting * fix: prevent crash after view destroyed * chore: cleanup and add license
|
Each item was approved individually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Many voting improvement PR's
Screenshots / Videos
How Has This Been Tested?
Checklist: