fix(dashpay): update image permissions for Android 13 and fix camera #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
changed the base branch from
dashpay
to
dashpay-feature-coinjoin-synced
HashEngineering
commented
Dec 6, 2023
| @@ -73,6 +73,7 @@ class CropImageActivity : LockScreenActivity() { | |||
| override fun onCreate(savedInstanceState: Bundle?) { | |||
| super.onCreate(savedInstanceState) | |||
| binding = ActivityCropImageBinding.inflate(layoutInflater) | |||
| setContentView(binding.root) | |||
There was a problem hiding this comment.
This was left out from the previous refactoring.
HashEngineering
changed the title
HashEngineering
commented
Dec 8, 2023
Comment on lines
-20
to
+21
| <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/> | ||
| <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32"/> | ||
| <uses-permission android:name="android.permission.READ_MEDIA_IMAGES"/> |
There was a problem hiding this comment.
This is the main change for Android 13.
HashEngineering
commented
Dec 8, 2023
Comment on lines
+221
to
+226
| takePictureLauncher = registerForActivityResult(ActivityResultContracts.TakePicture()) { isSuccess: Boolean -> | ||
| if (isSuccess) { | ||
| editProfileViewModel.onTmpPictureReadyForEditEvent.postValue(editProfileViewModel.tmpPictureFile) | ||
| } | ||
| turnOnAutoLogout() | ||
| } |
There was a problem hiding this comment.
This refactoring also solved the problem of failure of the camera on Android 12 and 14 emulators, though the old code did work on a real Android 13 device.
HashEngineering
commented
Dec 12, 2023
| @@ -199,6 +199,6 @@ class HistoryHeaderAdapter( | |||
|
|
|||
| private fun shouldShowJoinDashPay(canJoin: Boolean): Boolean { | |||
| val hideJoinDashPay = preferences.getBoolean(PREFS_KEY_HIDE_JOIN_DASHPAY_CARD, false) | |||
| return blockchainIdentityData == null && canJoin && !hideJoinDashPay | |||
| return blockchainIdentityData?.creationState == BlockchainIdentityData.CreationState.NONE && canJoin && !hideJoinDashPay | |||
There was a problem hiding this comment.
This is what will show the Join DashPay on the home screen. Changes regarding blockchainIdentityData (perhaps migration from a DB table to DataStore) broke this and always returned false.
HashEngineering
changed the base branch from
dashpay-feature-coinjoin-synced
to
dashpay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: