Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(dashpay): display coinjoin mixing info #1224

Merged
merged 26 commits into from
Nov 21, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Nov 3, 2023
@HashEngineering HashEngineering changed the title Dashpay coinjoin mixing info feature(dashpay): display coinjoin mixing info Nov 6, 2023
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

import org.bitcoinj.wallet.CoinSelection
import org.bitcoinj.wallet.Wallet

// refactor this class and derive it from MaxOutputAmountCoinSelector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be TODO?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a TODO, but now it is done. I will remove this.

MaxOutputAmountCoinJoinCoinSelector(wallet)
// MaxOutputAmountCoinSelector()
}
}
Copy link
Member

@Syn-McJ Syn-McJ Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we could improve this later to avoid checking for CoinJoin mode every time we need a balance. For example, MaxOutputAmountCoinJoinCoinSelector can check itself if coinjoin is on, and fallback to MaxOutputAmountCoinSelector if it isn't.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that is a good idea. I was trying to keep CoinJoin mode out of Send related View Models.

@HashEngineering HashEngineering changed the base branch from dashpay-coinjoin-wallet to dashpay November 21, 2023 19:07
@HashEngineering HashEngineering merged commit e6b6144 into dashpay Nov 21, 2023
2 checks passed
@HashEngineering HashEngineering deleted the dashpay-coinjoin-mixing-info branch January 5, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants