-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(dashpay): display coinjoin mixing info #1224
Conversation
… dashpay-core-20
…dash-wallet into dashpay-coinjoin-mixing-info
…dash-wallet into dashpay-coinjoin-mixing-info
… dashpay-coinjoin-wallet
…dash-wallet into dashpay-coinjoin-mixing-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
import org.bitcoinj.wallet.CoinSelection | ||
import org.bitcoinj.wallet.Wallet | ||
|
||
// refactor this class and derive it from MaxOutputAmountCoinSelector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to be TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a TODO, but now it is done. I will remove this.
MaxOutputAmountCoinJoinCoinSelector(wallet) | ||
// MaxOutputAmountCoinSelector() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we could improve this later to avoid checking for CoinJoin mode every time we need a balance. For example, MaxOutputAmountCoinJoinCoinSelector
can check itself if coinjoin is on, and fallback to MaxOutputAmountCoinSelector
if it isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, that is a good idea. I was trying to keep CoinJoin mode out of Send related View Models.
… dashpay-coinjoin-mixing-info
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: