Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashpay): only set tx icon in updateIcon method #1219

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix(dashpay): only set tx icon in updateIcon method #1219

merged 1 commit into from
Oct 18, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 16, 2023

TransactionResultViewBinder has some extra code related to setting the icon that should be removed.

Issue being fixed or feature implemented

  • Remove all icon-setting code except for updateIcon

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Oct 16, 2023
HashEngineering
HashEngineering approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HashEngineering HashEngineering merged commit ad3a72d into dashpay Oct 18, 2023
@HashEngineering HashEngineering deleted the dashpay-animatable-icon branch November 21, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashEngineering HashEngineering HashEngineering approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @HashEngineering