Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent exif nullptr (DEV-4521) #464

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

siers
Copy link
Contributor

@siers siers commented Jan 21, 2025

Lessons learned: if a shared_ptr isn't null, that doesn't mean shared_ptr.get() isn't.

Copy link

linear bot commented Jan 21, 2025

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.2%. Comparing base (de9e393) to head (9b5d6dd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/SipiImage.cpp 0.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/SipiImage.cpp 24.5% <0.0%> (-0.1%) ⬇️

... and 6 files with indirect coverage changes

@siers siers requested a review from seakayone January 21, 2025 13:25
@siers siers merged commit 4231f00 into main Jan 21, 2025
8 of 9 checks passed
@siers siers deleted the fix/DEV-4521-prevent-exif-nullptr branch January 21, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants