Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add copyright holder and authorship to filevalue #3459

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

seakayone
Copy link
Contributor

  • Move Copyright and Licenses relevant models out of the KnoraProject
  • add Authorship value class
  • add LicenseDate value class
  • rename copyright attribution to copyright holder
  • add hasAuthorship and hasLicenseDate
  • update knora-base version
  • add ResourcesResponderV2 test for copyright and licenses infos
  • add date writing and reading
  • add authorship writing

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title feat/add copyright holder and authorship to filevalue feat: Add copyright holder and authorship to filevalue Jan 15, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 85.14851% with 30 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (6ebe8e7) to head (c3c1955).
Report is 170 commits behind head on main.

Files with missing lines Patch % Lines
...s/v2/responder/valuemessages/ValueMessagesV2.scala 79.06% 9 Missing ⚠️
...g/knora/webapi/slice/common/jena/ResourceOps.scala 52.63% 9 Missing ⚠️
...webapi/messages/util/ConstructResponseUtilV2.scala 87.80% 5 Missing ⚠️
...esponder/valuemessages/ValueMessagesV2Optics.scala 0.00% 4 Missing ⚠️
...tore/triplestoremessages/TriplestoreMessages.scala 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3459      +/-   ##
==========================================
- Coverage   83.04%   82.56%   -0.48%     
==========================================
  Files         290      311      +21     
  Lines       23087    22859     -228     
==========================================
- Hits        19172    18874     -298     
- Misses       3915     3985      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant