Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Small refactoring #3311

Merged
merged 1 commit into from
Jul 9, 2024
Merged

refactor: Small refactoring #3311

merged 1 commit into from
Jul 9, 2024

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Some of the very first Scala code I ever wrote... and it shows!

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Jul 9, 2024
@BalduinLandolt BalduinLandolt marked this pull request as ready for review July 9, 2024 06:45
siers
siers approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@BalduinLandolt BalduinLandolt merged commit 6822d16 into main Jul 9, 2024
9 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/refactor-bothersome-code branch July 9, 2024 07:50
@daschbot daschbot mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siers siers siers approved these changes

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

@seakayone seakayone Awaiting requested review from seakayone seakayone is a code owner

Assignees

@BalduinLandolt BalduinLandolt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BalduinLandolt @siers