Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate ListRouteV2 to tapir (DEV-3852) #3307

Merged
merged 13 commits into from
Jul 8, 2024
Merged

refactor: Migrate ListRouteV2 to tapir (DEV-3852) #3307

merged 13 commits into from
Jul 8, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jul 5, 2024 •
edited
Loading

  • Migrate list route v2 to tapir
  • Remove MessageHandler from ListsResponderV2 and unused *Request message classes
  • Include listsV2 endpoints in ApiV2Endpoints
  • Rename ListResponderV2 -> ListService, use ListIri as method parameters

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title refactor/migrate to tapir refactor: Migrate ListRouteV2 to tapir Jul 5, 2024
@seakayone seakayone changed the title refactor: Migrate ListRouteV2 to tapir refactor: Migrate ListRouteV2 to tapir (DEV-3852) Jul 5, 2024
@linear Linear
Copy link

linear bot commented Jul 5, 2024

DEV-3852 Migrate ListsRoutV2 to tapir

@seakayone seakayone marked this pull request as ready for review July 5, 2024 13:36
BalduinLandolt
BalduinLandolt approved these changes Jul 8, 2024
View reviewed changes
webapi/src/main/scala/org/knora/webapi/slice/SliceModule.scala
inline def layer: ZLayer[RIn, E, ROut]
def layer: ZLayer[RIn, E, ROut]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (out of curiosity): what's the motivation for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some compile errors. I did not investigate further, maybe it was my mistake, maybe there is a compiler limitation.
The inline is not really necessary and not much of an optimisation. After all, the layers are only ever assembled once for the creation of the app.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, makes sense

siers
siers approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. :)

@seakayone seakayone enabled auto-merge (squash) July 8, 2024 09:38
@seakayone seakayone merged commit 9b3d6c7 into main Jul 8, 2024
9 checks passed
@seakayone seakayone deleted the refactor/migrate-to-tapir branch July 8, 2024 09:54
@daschbot daschbot mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@siers siers siers approved these changes

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @BalduinLandolt