Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev to 3.0.0 #319

Closed
wants to merge 2 commits into from
Closed

rev to 3.0.0 #319

wants to merge 2 commits into from

Conversation

devoncarew
Copy link
Member

  • rev to 3.0.0 to account for breaking API changes introduced in 2.4.1 (see 2.4.1 seems to have introduced breaking changes #307 for context)
  • adjust the CI to test against both the latest and oldest versions of package dependencies
  • misc updates to the readme and docs

This 3.0.0 version is substantially the same as the content from 2.4.1.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

We'd need to coordinate with package:test when rolling this out:

Because test >=1.16.3 <1.16.6 depends on web_socket_channel >=1.0.0 <3.0.0 and test >=1.16.0-nullsafety.8 <1.16.3 depends on web_socket_channel ^1.0.0, test >=1.16.0-nullsafety.8 <1.16.6 requires web_socket_channel >=1.0.0 <3.0.0.
And because test >=1.16.6 depends on web_socket_channel ^2.0.0, test >=1.16.0-nullsafety.8 requires web_socket_channel >=1.0.0 <3.0.0.
So, because web_socket_channel depends on test ^1.16.0 and web_socket_channel is 3.0.0, version solving failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant