Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renames where the type doesn't exist anymore #334

Merged
merged 4 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## 1.2.0-wip
- Added missing `FileReader` event getters: `onAbort`, `onError`, `onLoad`,
`onLoadStart`, `onProgress`.
- Removed renames `UnderlyingSource` and `UnderlyingSourceBase` where the types
don't exist.

## 1.1.0

Expand Down
9 changes: 0 additions & 9 deletions web/lib/fix_data.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1187,15 +1187,6 @@ transforms:
changes:
- kind: 'rename'
newName: 'HTMLUListElement'
# UnderlyingSourceBase => UnderlyingSource
- title: "Rename to 'UnderlyingSource'"
date: 2024-01-12
element:
uris: [ 'package:web/web.dart' ]
class: 'UnderlyingSourceBase'
changes:
- kind: 'rename'
newName: 'UnderlyingSource'
# UnknownElement => HTMLUnknownElement
- title: "Rename to 'HTMLUnknownElement'"
date: 2024-01-12
Expand Down
1 change: 0 additions & 1 deletion web/renames.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@
| TrackElement | HTMLTrackElement |
| TrustedUrl | |
| UListElement | HTMLUListElement |
| UnderlyingSourceBase | UnderlyingSource |
| UnknownElement | HTMLUnknownElement |
| Url | URL |
| UrlSearchParams | URLSearchParams |
Expand Down
1 change: 0 additions & 1 deletion web/test_fixes/renames.dart
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ late TimeElement $138;
late TitleElement $139;
late TrackElement $140;
late UListElement $143;
late UnderlyingSourceBase $144;
late UnknownElement $145;
late Url $146;
late UrlSearchParams $147;
Expand Down
1 change: 0 additions & 1 deletion web/test_fixes/renames.dart.expect
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ late HTMLTimeElement $138;
late HTMLTitleElement $139;
late HTMLTrackElement $140;
late HTMLUListElement $143;
late UnderlyingSource $144;
late HTMLUnknownElement $145;
late URL $146;
late URLSearchParams $147;
Expand Down
Loading