Remove renames where the type doesn't exist anymore (#334)

* Remove renames where the type doesn't exist anymore * add changes to CHANGELOG.md * move changes to 1.2.0-wip
dart-lang · Jan 9, 2025 · 7f440e4 · 7f440e4
1 parent 3b06da9
commit 7f440e4
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 12 deletions.
diff --git a/web/CHANGELOG.md b/web/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## 1.2.0-wip
 - Added missing `FileReader` event getters: `onAbort`, `onError`, `onLoad`,
   `onLoadStart`, `onProgress`.
+- Removed renames `UnderlyingSource` and `UnderlyingSourceBase` where the types 
+  don't exist.
 
 ## 1.1.0
 

diff --git a/web/lib/fix_data.yaml b/web/lib/fix_data.yaml
@@ -1187,15 +1187,6 @@ transforms:
     changes:
       - kind: 'rename'
         newName: 'HTMLUListElement'
-  # UnderlyingSourceBase => UnderlyingSource
-  - title: "Rename to 'UnderlyingSource'"
-    date: 2024-01-12
-    element:
-      uris: [ 'package:web/web.dart' ]
-      class: 'UnderlyingSourceBase'
-    changes:
-      - kind: 'rename'
-        newName: 'UnderlyingSource'
   # UnknownElement => HTMLUnknownElement
   - title: "Rename to 'HTMLUnknownElement'"
     date: 2024-01-12

diff --git a/web/renames.md b/web/renames.md
@@ -184,7 +184,6 @@
 | TrackElement                  | HTMLTrackElement              |
 | TrustedUrl                    |                               |
 | UListElement                  | HTMLUListElement              |
-| UnderlyingSourceBase          | UnderlyingSource              |
 | UnknownElement                | HTMLUnknownElement            |
 | Url                           | URL                           |
 | UrlSearchParams               | URLSearchParams               |

diff --git a/web/test_fixes/renames.dart b/web/test_fixes/renames.dart
@@ -135,7 +135,6 @@ late TimeElement $138;
 late TitleElement $139;
 late TrackElement $140;
 late UListElement $143;
-late UnderlyingSourceBase $144;
 late UnknownElement $145;
 late Url $146;
 late UrlSearchParams $147;

diff --git a/web/test_fixes/renames.dart.expect b/web/test_fixes/renames.dart.expect
@@ -135,7 +135,6 @@ late HTMLTimeElement $138;
 late HTMLTitleElement $139;
 late HTMLTrackElement $140;
 late HTMLUListElement $143;
-late UnderlyingSource $144;
 late HTMLUnknownElement $145;
 late URL $146;
 late URLSearchParams $147;