-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support handling classDecl fromJson(String s) in JsonDecodable #56665
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/383930 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/384161 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
Reviewed at the Gerrit CL, https://dart-review.googlesource.com/c/sdk/+/384161 |
Hi @morlay are you still working on this? If so, please respond in the Gerrit link. |
Sorry. I have network issue to access googlesource. |
5e73fc4
to
b39d072
Compare
https://dart-review.googlesource.com/c/sdk/+/384161 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/384161 has been updated with the latest commits from this pull request. |
Hi @morlay are you still not able to access https://dart-review.googlesource.com/c/sdk/+/384161? There are some open comments there. |
https://dart-review.googlesource.com/c/sdk/+/384161 has been updated with the latest commits from this pull request. |
To support usage like