[kernel] BinaryReader takes Uint8List, not List<int>

In AOT this makes reading faster:

Output from `out/ReleaseX64/dart pkg/front_end/tool/benchmarker.dart --iterations=10 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.1 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.2 --arguments="--warmups=10" --arguments="--iterations=5" --arguments="AstFromBinaryEager" --arguments="out/ReleaseX64/vm_platform_strong.dill"`:

```
msec task-clock:u: -8.6925% +/- 0.5737% (-167.09 +/- 11.03)
page-faults:u: 0.1410% +/- 0.0051% (243.00 +/- 8.71)
cycles:u: -10.2918% +/- 0.6161% (-732576747.50 +/- 43853449.16)
instructions:u: -14.4988% +/- 0.0004% (-1636799813.90 +/- 39902.18)
branch-misses:u: -3.4891% +/- 2.1142% (-1166085.00 +/- 706582.35)
seconds time elapsed: -8.7005% +/- 0.5634% (-0.17 +/- 0.01)
seconds user: -9.9752% +/- 1.5104% (-0.17 +/- 0.03)
```

Stats running manually (run as e.g. `out/ReleaseX64/dart-sdk/bin/dartaotruntime pkg/front_end/test/kernel_binary_bench.aot.1 --warmups=10 --iterations=5 AstFromBinaryEager out/ReleaseX64/vm_platform_strong.dill`):

```
AstFromBinaryEagerCold: -12.5174% +/- 3.10688%
AstFromBinaryEagerWarmup: -8.33675% +/- 2.62433%
AstFromBinaryEager: -10.3432% +/- 3.68375%
```

I don't expect there to be much of a change (if any) in JIT as the actual type was in practise always Uint8List anyway.

TEST=Existing tests.

Change-Id: I86b16ed207343848dee2e376f42598c223bbc48f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393740
Reviewed-by: Mayank Patke <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Morgan :) <[email protected]>
Reviewed-by: Srujan Gaddam <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>

pkg/build_integration/lib/file_system/multi_root.dart

@@ -85,7 +85,7 @@ class MultiRootFileSystemEntity implements FileSystemEntity {
   Future<Uint8List> readAsBytes() async => (await delegate).readAsBytes();
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() async =>
+  Future<Uint8List> readAsBytesAsyncIfPossible() async =>
       (await delegate).readAsBytes();
 
   @override
@@ -109,7 +109,7 @@ class MissingFileSystemEntity implements FileSystemEntity {
       Future.error(FileSystemException(uri, 'File not found'));
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   Future<String> readAsString() =>

pkg/build_integration/lib/file_system/single_root.dart

@@ -73,7 +73,7 @@ class SingleRootFileSystemEntity implements FileSystemEntity {
   Future<Uint8List> readAsBytes() async => delegate.readAsBytes();
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() async =>
+  Future<Uint8List> readAsBytesAsyncIfPossible() async =>
       delegate.readAsBytesAsyncIfPossible();
 
   @override

pkg/compiler/lib/src/kernel/front_end_adapter.dart

@@ -68,7 +68,7 @@ class _CompilerFileSystemEntity implements fe.FileSystemEntity {
   }
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   Future<bool> exists() async {

pkg/compiler/lib/src/phase/load_kernel.dart

@@ -417,7 +417,7 @@ Future<Output?> run(Input input) async {
   if (component == null) return null;
   if (input.forceSerialization) {
     // TODO(johnniwinther): Remove this when #34942 is fixed.
-    List<int> data = fe.serializeComponent(component);
+    Uint8List data = fe.serializeComponent(component);
     component = ir.Component();
     BinaryBuilder(data).readComponent(component);
     // Ensure we use the new deserialized entry point library.

pkg/compiler/lib/src/serialization/strategies.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
+import 'dart:typed_data';
 
 import 'package:front_end/src/api_unstable/dart2js.dart' as ir
     show serializeComponent, ByteSink;
@@ -22,7 +23,7 @@ import 'task.dart';
 abstract class SerializationStrategy<T> {
   const SerializationStrategy();
 
-  List<int> unpackAndSerializeComponent(GlobalTypeInferenceResults results) {
+  Uint8List unpackAndSerializeComponent(GlobalTypeInferenceResults results) {
     JClosedWorld closedWorld = results.closedWorld;
     ir.Component component = closedWorld.elementMap.programEnv.mainComponent;
     return serializeComponent(component);
@@ -33,11 +34,11 @@ abstract class SerializationStrategy<T> {
       CompilerOptions options,
       SerializationIndices indices);
 
-  List<int> serializeComponent(ir.Component component) {
+  Uint8List serializeComponent(ir.Component component) {
     return ir.serializeComponent(component);
   }
 
-  ir.Component deserializeComponent(List<int> data) {
+  ir.Component deserializeComponent(Uint8List data) {
     ir.Component component = ir.Component();
     BinaryBuilder(data).readComponent(component);
     return component;

pkg/compiler/test/serialization/serialization_test_helper.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
+import 'dart:typed_data';
 
 import 'package:compiler/compiler_api.dart' as api;
 import 'package:compiler/src/commandline_options.dart';
@@ -273,7 +274,7 @@ JClosedWorld cloneClosedWorld(Compiler compiler, JClosedWorld closedWorld,
     SerializationStrategy strategy) {
   SerializationIndices indices = SerializationIndices();
   ir.Component component = closedWorld.elementMap.programEnv.mainComponent;
-  List<int> irData = strategy.serializeComponent(component);
+  Uint8List irData = strategy.serializeComponent(component);
   final closedWorldData = strategy.serializeClosedWorld(
       closedWorld, compiler.options, indices) as List<int>;
   print('data size: ${closedWorldData.length}');
@@ -302,7 +303,7 @@ JClosedWorld cloneClosedWorld(Compiler compiler, JClosedWorld closedWorld,
 GlobalTypeInferenceResults cloneInferenceResults(Compiler compiler,
     GlobalTypeInferenceResults results, SerializationStrategy strategy) {
   SerializationIndices indices = SerializationIndices(testMode: true);
-  List<int> irData = strategy.unpackAndSerializeComponent(results);
+  Uint8List irData = strategy.unpackAndSerializeComponent(results);
   final closedWorldData = strategy.serializeClosedWorld(
       results.closedWorld, compiler.options, indices) as List<int>;
   ir.Component newComponent = strategy.deserializeComponent(irData);

pkg/dev_compiler/lib/src/kernel/asset_file_system.dart

@@ -98,7 +98,7 @@ class AssetFileSystemEntity implements FileSystemEntity {
   }
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   Future<String> readAsString() async {

pkg/front_end/lib/src/api_prototype/file_system.dart

@@ -81,7 +81,7 @@ abstract class FileSystemEntity {
   /// If an error occurs while attempting to read the file (e.g. because no such
   /// file exists, or the entity is a directory), the future is completed with
   /// [FileSystemException].
-  Future<List<int>> readAsBytesAsyncIfPossible();
+  Future<Uint8List> readAsBytesAsyncIfPossible();
 
   /// Attempts to access this file system entity as a file and read its contents
   /// as a string.

pkg/front_end/lib/src/api_prototype/kernel_generator.dart

@@ -5,6 +5,8 @@
 /// Defines the front-end API for converting source code to Dart Kernel objects.
 library front_end.kernel_generator;
 
+import 'dart:typed_data';
+
 import 'package:_fe_analyzer_shared/src/messages/codes.dart'
     show messageMissingMain, noLength;
 import 'package:_fe_analyzer_shared/src/messages/severity.dart' show Severity;
@@ -109,7 +111,7 @@ Future<CompilerResult> kernelForModule(
 /// Result object for [kernelForProgram] and [kernelForModule].
 abstract class CompilerResult {
   /// The generated summary bytes, if it was requested.
-  List<int>? get summary;
+  Uint8List? get summary;
 
   /// The generated component, if it was requested.
   Component? get component;

pkg/front_end/lib/src/api_prototype/memory_file_system.dart

@@ -105,7 +105,7 @@ class MemoryFileSystemEntity implements FileSystemEntity {
 
   @override
   // Coverage-ignore(suite): Not run.
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   // Coverage-ignore(suite): Not run.

pkg/front_end/lib/src/api_prototype/standard_file_system.dart

@@ -103,7 +103,7 @@ class _IoFileSystemEntity implements FileSystemEntity {
 
   @override
   // Coverage-ignore(suite): Not run.
-  Future<List<int>> readAsBytesAsyncIfPossible() async {
+  Future<Uint8List> readAsBytesAsyncIfPossible() async {
     try {
       FileSystemDependencyTracker.recordDependency(tracker, uri);
       return await new io.File.fromUri(uri).readAsBytes();
@@ -168,7 +168,7 @@ class DataFileSystemEntity implements FileSystemEntity {
   Future<bool> existsAsyncIfPossible() => exists();
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   Future<String> readAsString() {

pkg/front_end/lib/src/api_prototype/summary_generator.dart

@@ -5,6 +5,8 @@
 /// Defines the front-end API for converting source code to summaries.
 library front_end.summary_generator;
 
+import 'dart:typed_data';
+
 import '../base/processed_options.dart';
 import '../kernel_generator_impl.dart';
 import 'compiler_options.dart';
@@ -28,7 +30,7 @@ import 'compiler_options.dart';
 /// was compiled from sources.
 ///
 /// The return value is a list of bytes to write to the summary file.
-Future<List<int>?> summaryFor(List<Uri> sources, CompilerOptions options,
+Future<Uint8List?> summaryFor(List<Uri> sources, CompilerOptions options,
     {bool truncate = false}) async {
   return (await generateKernel(
           new ProcessedOptions(options: options, inputs: sources),

pkg/front_end/lib/src/api_unstable/modular_incremental_compilation.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'dart:typed_data';
+
 import 'package:kernel/kernel.dart' show Component, CanonicalName, Library;
 import 'package:kernel/target/targets.dart' show Target;
 import 'package:macros/src/executor/serialization.dart' show SerializationMode;
@@ -212,7 +214,7 @@ Future<InitializedCompilerState> initializeIncrementalCompiler(
           throw new StateError("Expected to get digest for $additionalDillUri");
         }
 
-        List<int> bytes =
+        Uint8List bytes =
             await fileSystem.entityForUri(additionalDillUri).readAsBytes();
         WorkerInputComponent cachedInput = new WorkerInputComponent(
             digest,

pkg/front_end/lib/src/base/get_dependencies.dart

@@ -4,6 +4,8 @@
 
 library fasta.get_dependencies;
 
+import 'dart:typed_data';
+
 import 'package:kernel/kernel.dart' show Component, loadComponentFromBytes;
 import 'package:kernel/target/targets.dart' show Target;
 
@@ -41,7 +43,7 @@ Future<List<Uri>> getDependencies(Uri script,
     DillTarget dillTarget =
         new DillTarget(c, c.options.ticker, uriTranslator, c.options.target);
     if (platform != null) {
-      List<int> bytes = await fileSystem.entityForUri(platform).readAsBytes();
+      Uint8List bytes = await fileSystem.entityForUri(platform).readAsBytes();
       Component platformComponent = loadComponentFromBytes(bytes);
       dillTarget.loader.appendLibraries(platformComponent);
     }

pkg/front_end/lib/src/base/hybrid_file_system.dart

@@ -70,7 +70,7 @@ class HybridFileSystemEntity implements FileSystemEntity {
 
   @override
   // Coverage-ignore(suite): Not run.
-  Future<List<int>> readAsBytesAsyncIfPossible() async =>
+  Future<Uint8List> readAsBytesAsyncIfPossible() async =>
       (await delegate).readAsBytesAsyncIfPossible();
 
   @override

pkg/front_end/lib/src/base/incremental_compiler.dart

@@ -2509,15 +2509,15 @@ class _InitializationFromSdkSummary extends _InitializationStrategy {
       _ComponentProblems componentProblems,
       IncrementalSerializer? incrementalSerializer,
       RecorderForTesting? recorderForTesting) async {
-    List<int>? summaryBytes = await context.options.loadSdkSummaryBytes();
+    Uint8List? summaryBytes = await context.options.loadSdkSummaryBytes();
     return _prepareSummary(
         dillLoadedData, summaryBytes, uriTranslator, context, data);
   }
 
   // Coverage-ignore(suite): Not run.
   int _prepareSummary(
       DillTarget dillLoadedTarget,
-      List<int>? summaryBytes,
+      Uint8List? summaryBytes,
       UriTranslator uriTranslator,
       CompilerContext context,
       IncrementalCompilerData data) {
@@ -2607,7 +2607,7 @@ class _InitializationFromUri extends _InitializationFromSdkSummary {
       _ComponentProblems componentProblems,
       IncrementalSerializer? incrementalSerializer,
       RecorderForTesting? recorderForTesting) async {
-    List<int>? summaryBytes = await context.options.loadSdkSummaryBytes();
+    Uint8List? summaryBytes = await context.options.loadSdkSummaryBytes();
     int bytesLength = _prepareSummary(
         dillLoadedData, summaryBytes, uriTranslator, context, data);
     try {
@@ -2685,7 +2685,7 @@ class _InitializationFromUri extends _InitializationFromSdkSummary {
     FileSystemEntity entity =
         context.options.fileSystem.entityForUri(initializeFromDillUri);
     if (await entity.exists()) {
-      List<int> initializationBytes = await entity.readAsBytes();
+      Uint8List initializationBytes = await entity.readAsBytes();
       if (initializationBytes.isNotEmpty) {
         dillLoadedData.ticker.logMs("Read $initializeFromDillUri");
         data.initializationBytes = initializationBytes;

pkg/front_end/lib/src/base/processed_options.dart

@@ -143,12 +143,12 @@ class ProcessedOptions {
     return _sdkSummary;
   }
 
-  List<int>? _sdkSummaryBytes;
+  Uint8List? _sdkSummaryBytes;
   bool _triedLoadingSdkSummary = false;
 
   // Coverage-ignore(suite): Not run.
   /// Get the bytes of the SDK outline, if any.
-  Future<List<int>?> loadSdkSummaryBytes() async {
+  Future<Uint8List?> loadSdkSummaryBytes() async {
     if (_sdkSummaryBytes == null && !_triedLoadingSdkSummary) {
       if (sdkSummary == null) return null;
       FileSystemEntity entry = fileSystem.entityForUri(sdkSummary!);
@@ -537,7 +537,7 @@ class ProcessedOptions {
     if (_sdkSummaryComponent == null) {
       // Coverage-ignore-block(suite): Not run.
       if (sdkSummary == null) return null;
-      List<int>? bytes = await loadSdkSummaryBytes();
+      Uint8List? bytes = await loadSdkSummaryBytes();
       if (bytes != null && bytes.isNotEmpty) {
         _sdkSummaryComponent =
             loadComponent(bytes, nameRoot, fileUri: sdkSummary);
@@ -563,11 +563,11 @@ class ProcessedOptions {
       List<Uri> uris = _raw.additionalDills;
       if (uris.isEmpty) return const <Component>[];
       // TODO(sigmund): throttle # of concurrent operations.
-      List<List<int>?> allBytes = await Future.wait(
+      List<Uint8List?> allBytes = await Future.wait(
           uris.map((uri) => _readAsBytes(fileSystem.entityForUri(uri))));
       List<Component> result = [];
       for (int i = 0; i < uris.length; i++) {
-        List<int>? bytes = allBytes[i];
+        Uint8List? bytes = allBytes[i];
         if (bytes == null) continue;
         result.add(loadComponent(bytes, nameRoot, fileUri: uris[i]));
       }
@@ -578,7 +578,7 @@ class ProcessedOptions {
 
   // Coverage-ignore(suite): Not run.
   /// Helper to load a .dill file from [uri] using the existing [nameRoot].
-  Component loadComponent(List<int> bytes, CanonicalName? nameRoot,
+  Component loadComponent(Uint8List bytes, CanonicalName? nameRoot,
       {bool? alwaysCreateNewNamedNodes, Uri? fileUri}) {
     Component component =
         target.configureComponent(new Component(nameRoot: nameRoot));
@@ -950,7 +950,7 @@ class ProcessedOptions {
   }
 
   // Coverage-ignore(suite): Not run.
-  Future<List<int>?> _readAsBytes(FileSystemEntity file) async {
+  Future<Uint8List?> _readAsBytes(FileSystemEntity file) async {
     try {
       return await file.readAsBytes();
     } on FileSystemException catch (error) {

pkg/front_end/lib/src/kernel_generator_impl.dart

@@ -5,6 +5,8 @@
 /// Defines the front-end API for converting source code to Dart Kernel objects.
 library front_end.kernel_generator_impl;
 
+import 'dart:typed_data';
+
 import 'package:_fe_analyzer_shared/src/messages/severity.dart' show Severity;
 import 'package:kernel/ast.dart';
 import 'package:kernel/class_hierarchy.dart';
@@ -177,7 +179,7 @@ Future<InternalCompilerResult> _buildInternal(CompilerContext compilerContext,
   BuildResult buildResult =
       await kernelTarget.buildOutlines(nameRoot: nameRoot);
   Component summaryComponent = buildResult.component!;
-  List<int>? summary = null;
+  Uint8List? summary = null;
   if (buildSummary) {
     // Coverage-ignore-block(suite): Not run.
     if (options.verify) {
@@ -278,7 +280,7 @@ Future<InternalCompilerResult> _buildInternal(CompilerContext compilerContext,
 class InternalCompilerResult implements CompilerResult {
   /// The generated summary bytes, if it was requested.
   @override
-  final List<int>? summary;
+  final Uint8List? summary;
 
   /// The generated component, if it was requested.
   @override

pkg/front_end/lib/src/testing/compiler_common.dart

@@ -5,6 +5,8 @@
 /// Common compiler options and helper functions used for testing.
 library front_end.testing.compiler_options_common;
 
+import 'dart:typed_data';
+
 import 'package:kernel/ast.dart' show Library, Component;
 
 import '../api_prototype/front_end.dart'
@@ -61,7 +63,7 @@ Future<Component?> compileUnit(
 /// Generate a summary for a modular compilation unit.
 ///
 /// Wraps [summaryFor] with some default testing options (see [setup]).
-Future<List<int>?> summarize(List<String> inputs, Map<String, dynamic> sources,
+Future<Uint8List?> summarize(List<String> inputs, Map<String, dynamic> sources,
     {List<String> additionalDills = const [],
     CompilerOptions? options,
     bool truncate = false}) async {

pkg/front_end/test/analyser_ignored/load_dill_twice_test.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io' show Platform, exit;
+import 'dart:typed_data';
 
 import 'package:kernel/binary/ast_from_binary.dart' show BinaryBuilder;
 import 'package:kernel/kernel.dart' show Component;
@@ -11,7 +12,7 @@ import 'package:kernel/text/ast_to_text.dart' show componentToString;
 import '../incremental_suite.dart' show normalCompileToBytes;
 
 main() async {
-  List<int> bytes = await normalCompileToBytes(
+  Uint8List bytes = await normalCompileToBytes(
       Platform.script.resolve("load_dill_twice_lib_1.dart"));
 
   Component c = new Component();