Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jnigen] Support Kotlin operators #1969

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[jnigen] Support Kotlin operators #1969

merged 1 commit into from
Feb 5, 2025

Conversation

HosseinYousefi
Copy link
Member

Generate +, -, *, /, %, [], []= operators in Dart. Some of Dart operators don't exist in Kotlin and vice-versa. These are the group of operators that make sense. Also we only generate them if they fit the Dart model (For example, [] can take multiple parameters in Kotlin, while in Dart it can only get 1). If there are multiple overloads, only generate the first matching one as an operator.

We still generate the original method, this is consistent with Kotlin, as a.add(b) and a + b are equivalent.

Copy link

github-actions bot commented Feb 4, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 87.388% (+0.03%) from 87.356%
when pulling 8b74bf4 on kotlin-operators
into b053b7b on main.

@HosseinYousefi HosseinYousefi merged commit 6290151 into main Feb 5, 2025
27 checks passed
@HosseinYousefi HosseinYousefi deleted the kotlin-operators branch February 5, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants