[native_assets_cli] Add outputDirectoryShared to config
#1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
github-actions
bot
added
the
type-infra
|
Offline discussion with @dcharkes - do not submit until new version has rolled into flutter. |
mosuem
approved these changes
Sep 13, 2024
| var cachedFiles = 0; | ||
|
|
||
| await for (final sourceFile in dataDirectory.list()) { | ||
| if (sourceFile is! File) { |
There was a problem hiding this comment.
nit: filter with whereType instead
There was a problem hiding this comment.
Stream doesn't have a whereType 😢
| } | ||
|
|
||
| final sourceName = | ||
| sourceFile.uri.pathSegments.lastWhere((e) => e.isNotEmpty); |
There was a problem hiding this comment.
In the old uri vs. Strings discussion - package:path has nice methods to get the basename of a file
There was a problem hiding this comment.
vs package:file 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example of in-hook caching and sharing work across multiple hook invocations:
The prime example can be found in
pkgs/native_assets_builder/test_data/transformer/.In order for the example to work correctly, a new
BuildConfig.outputDirectorySharedis added and locking is used to ensure that the same hook invoked twice concurrently with a different parameter doesn't cause concurrent modifications. (This should not regress Flutter builds, because these run hooks for the various targets in sequence.)This CL does not yet address some other issues: