Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example in Static access shorthand proposal #4182

Closed
wants to merge 3 commits into from

Conversation

sgrekhov
Copy link
Contributor

Endian.little is not an enum value but a static constant. Fixed comment and added a real enum value example.

@sgrekhov sgrekhov force-pushed the shorthand-example-fix branch from 4f2e740 to 89bb040 Compare December 2, 2024 14:16
lrhn and others added 2 commits December 2, 2024 18:41
Fix constant pattern, clean-up, and expansion of the constant section.

* Changes grammar for constant pattern to not allow full selector chain,
  only shorthands for `T.id` and `const T.(id|new)(args)`.
  so the shorthand doesn't accept more than the existing limited productions.
* No other grammatical or semantic changes intended.
* Expand the "Constants" section.
* Mention explicitly that a context type scheme is a semantic type,
  so it cannot refer to a type alias.
Bumps the github-actions group with 1 update: [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart).

Updates `dart-lang/setup-dart` from 1.6.5 to 1.7.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dart-lang/setup-dart/releases">dart-lang/setup-dart's releases</a>.</em></p>
<blockquote>
<h2>v1.7.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Install a Flutter SDK in the publish workflow allowing for publication of flutter packages.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md">dart-lang/setup-dart's changelog</a>.</em></p>
<blockquote>
<h2>v1.7.0</h2>
<ul>
<li>
<p>Install flutter sdk in publishing step, allowing Flutter packages to be
published (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/68">#68</a>[])</p>
<p><a href="https://redirect.github.com/dart-lang/setup-dart/issues/68">#68</a>: <a href="https://redirect.github.com/dart-lang/setup-dart/issues/68">dart-lang/setup-dart#68</a></p>
</li>
</ul>
<h2>v1.6.5</h2>
<ul>
<li>Fix zip path handling on Windows 11 (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/118">#118</a>[])</li>
</ul>
<p><a href="https://redirect.github.com/dart-lang/setup-dart/issues/118">#118</a>: <a href="https://redirect.github.com/dart-lang/setup-dart/issues/118">dart-lang/setup-dart#118</a></p>
<h2>v1.6.4</h2>
<ul>
<li>Rebuild JS code.</li>
</ul>
<h2>v1.6.3</h2>
<ul>
<li>Roll <code>undici</code> dependency to address <a href="https://github.com/nodejs/undici/security/advisories/GHSA-m4v8-wqvr-p9f7">CVE-2024-30260</a> and <a href="https://github.com/nodejs/undici/security/advisories/GHSA-9qxr-qj54-h672">CVE-2024-30261</a>.</li>
</ul>
<h2>v1.6.2</h2>
<ul>
<li>Switch to running the workflow on <code>node20`` from </code>node16`. See also
<a href="https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/">Transitioning from Node 16 to Node 20</a>.</li>
</ul>
<h2>v1.6.1</h2>
<ul>
<li>Updated the google storage url for <code>main</code> channel releases.</li>
</ul>
<h2>v1.6.0</h2>
<ul>
<li>Enable provisioning of the latest Dart SDK patch release by specifying just
the major and minor version (e.g. <code>3.2</code>).</li>
</ul>
<h2>v1.5.1</h2>
<ul>
<li>No longer test the <code>setup-dart</code> action on pre-2.12 SDKs.</li>
<li>Upgrade JS interop code to use extension types
(the new name for inline classes).</li>
<li>The upcoming rename of the <code>be</code> channel to <code>main</code> is now supported with
forward compatibility that switches when the rename happens.</li>
</ul>
<h2>v1.5.0</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dart-lang/setup-dart/commit/e630b99d28a3b71860378cafdc2a067c71107f94"><code>e630b99</code></a> Fix link in CHANGELOG.md (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/144">#144</a>)</li>
<li><a href="https://github.com/dart-lang/setup-dart/commit/cdcaf1297c175a0f0f1ec895cdbbee0479ddec2b"><code>cdcaf12</code></a> Update changelog (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/143">#143</a>)</li>
<li><a href="https://github.com/dart-lang/setup-dart/commit/c21802dc505e35765fa73ad4191bbe120ee94522"><code>c21802d</code></a> Install a Flutter SDK in the publish workflow (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/141">#141</a>)</li>
<li><a href="https://github.com/dart-lang/setup-dart/commit/f60b94591ab2d3da576c469969989fca99fabd3e"><code>f60b945</code></a> Update publish.yml (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/142">#142</a>)</li>
<li><a href="https://github.com/dart-lang/setup-dart/commit/d0b01d2ac509deeb2d41d27918204416ba9b1947"><code>d0b01d2</code></a> Bump <code>@�actions/core</code> from 1.10.1 to 1.11.1 (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/138">#138</a>)</li>
<li><a href="https://github.com/dart-lang/setup-dart/commit/f6a6f58cab9dd4e0ba15826bd89d4558877fd25c"><code>f6a6f58</code></a> Bump <code>@�actions/http-client</code> from 2.2.1 to 2.2.3 (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/137">#137</a>)</li>
<li><a href="https://github.com/dart-lang/setup-dart/commit/e9a814f39d5452701455a47847735e0f482026c8"><code>e9a814f</code></a> Bump dart-lang/setup-dart in the github-actions group (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/136">#136</a>)</li>
<li>See full diff in <a href="https://github.com/dart-lang/setup-dart/compare/0a8a0fc875eb934c15d08629302413c671d3f672...e630b99d28a3b71860378cafdc2a067c71107f94">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dart-lang/setup-dart&package-manager=github_actions&previous-version=1.6.5&new-version=1.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions

</details>
@sgrekhov sgrekhov marked this pull request as draft December 2, 2024 16:47
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Dec 2, 2024

Replaced by #4191

@sgrekhov sgrekhov closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants