Adjust objectPattern to allow Function()
#3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @lrhn, you'd prefer to keep the specification unchanged, run a breaking change process, and remove the support for |
|
I would. I expect it to not break any existing code, because nobody will have used it. If I'm much wrong about that, we should perhaps reconsider. |
|
We discussed this at the language meeting today and decided to keep the currently implemented behavior (which means that we do adopt the specification change which is performed by this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dart-lang/sdk#54246 where @modulovalue raised this issue.
This PR changes the syntax of
<objectPattern>such that it allowsFunctionto be the denotation of a type (for example:Function(: var toString)).The analyzer and the common front end already implement this behavior, hence there's no implementation effort.