Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ICU4X artifacts on tagging #825

Merged
merged 25 commits into from
Apr 30, 2024
Merged

Generate ICU4X artifacts on tagging #825

merged 25 commits into from
Apr 30, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Apr 10, 2024

Generate a new release whenever intl4x is released.

cc @robertbastian


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Apr 10, 2024
Copy link

github-actions bot commented Apr 10, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.8.2 already published at pub.dev
package:intl_translation 0.20.0-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem
Copy link
Member Author

mosuem commented Apr 11, 2024

The generation seems to fail on my test repo
https://github.com/mosuem/generate_icu4x_binaries/actions/runs/8643427617 for target linux_ia32. Is this expected @robertbastian ?

@robertbastian
Copy link
Collaborator

Yes, I need to investigate how to get the 32 bit libraries. I'd disable it for now.

@robertbastian
Copy link
Collaborator

@robertbastian
Copy link
Collaborator

robertbastian commented Apr 19, 2024

@robertbastian robertbastian marked this pull request as ready for review April 30, 2024 14:42
@mosuem mosuem merged commit da7fe86 into main Apr 30, 2024
12 checks passed
@mosuem mosuem deleted the generateICUArtifacts branch April 30, 2024 17:03
robertbastian added a commit to unicode-org/icu4x that referenced this pull request May 2, 2024
It was already deactivated and is now done in
dart-lang/i18n#825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants