Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify binaries using hashes #813

Merged
merged 26 commits into from
Jul 30, 2024
Merged

Verify binaries using hashes #813

merged 26 commits into from
Jul 30, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Mar 15, 2024

When downloading pre-compiled binaries from the CDN, check the hashes of the binaries to verify the correct file was downloaded.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Mar 15, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
intl4x Non-Breaking 0.9.2-wip 0.9.2-wip 0.9.2-wip ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/intl4x/hook/build.dart 💔 Not covered
pkgs/intl4x/hook/hashes.dart 💔 Not covered
pkgs/intl4x/hook/version.dart 💔 Not covered
pkgs/intl4x/tool/generate_hashes.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.9.2-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@dart-lang dart-lang deleted a comment from github-actions bot Apr 19, 2024
pkgs/intl4x/build.dart Outdated Show resolved Hide resolved
@mosuem mosuem force-pushed the verifyBinariesUsingHashes branch from 83ca7cd to a8d5b41 Compare July 3, 2024 13:43
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jul 3, 2024
@mosuem mosuem requested a review from robertbastian July 18, 2024 07:22
@mosuem mosuem force-pushed the verifyBinariesUsingHashes branch from 740960f to ca3f1ca Compare July 24, 2024 07:08
@mosuem mosuem changed the base branch from main to switchToCopying July 24, 2024 13:40
@mosuem mosuem changed the base branch from switchToCopying to main July 24, 2024 13:54
@mosuem mosuem force-pushed the verifyBinariesUsingHashes branch from ebccdca to 965ccf9 Compare July 24, 2024 15:01
@mosuem mosuem changed the title Verfiy binaries using hashes Verify binaries using hashes Jul 24, 2024
@mosuem mosuem requested a review from robertbastian July 25, 2024 15:05
@mosuem mosuem merged commit deeda2f into main Jul 30, 2024
30 checks passed
@mosuem mosuem deleted the verifyBinariesUsingHashes branch July 30, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants