Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissolve package:messages_deserializer for pub publish #751

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Nov 27, 2023

dart pub publish does not allow circular dependencies, which is probably for the best. So the deserialization logic is now in package:message.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:messages_serializer 0.1.0 ready to publish messages_serializer-v0.1.0
package:messages_builder 0.1.0 ready to publish messages_builder-v0.1.0
package:messages_shrinker 0.1.0 ready to publish messages_shrinker-v0.1.0
package:intl 0.19.0-dev ready to publish intl-v0.19.0-dev
package:messages 0.1.0 ready to publish messages-v0.1.0
package:intl_translation 0.19.0-wip WIP (no publish necessary)
package:intl4x 0.7.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the main readme also need to be updated (did it reference the deleted package)?

pkgs/messages/pubspec.yaml Show resolved Hide resolved
@mosuem
Copy link
Member Author

mosuem commented Nov 28, 2023

Does the main readme also need to be updated (did it reference the deleted package)?

It just references the main package:messages as of now.

@mosuem mosuem merged commit 2c82cd2 into main Nov 28, 2023
12 of 13 checks passed
@mosuem mosuem deleted the dissolveDeserializer branch November 28, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants