convert dartpad over to use styled_widget #3063
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts uses of
Padding
andCenter
to use extension method frompackage:styled_widget
. It may be interesting convert more code over to use the styled_widget extension methods, to better gauge changes to the readability of the code, ...Note that it looks like some parts of the github diff get confused by the changes - the delta looks bigger than it is.
I generally like the changes; it reduces the level of nesting, making it easier to work within 80 cols. And suspect that I'd like having the modifier methods trail after the main widgets, esp. if we used more of the extension methods (so,
Foo(...).padding(...).center().background(...)
).Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.