Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show dartdoc documentation in a model dialog #3047

Merged
merged 1 commit into from
Aug 27, 2024
Merged

show dartdoc documentation in a model dialog #3047

merged 1 commit into from
Aug 27, 2024

Conversation

devoncarew
Copy link
Member

  • move our dartdoc display from a in-line panel to a modal dialog; the docs dialog is opened by a new FAB, next to the format button

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Screenshot 2024-08-27 at 11 43 20 AM Screenshot 2024-08-27 at 11 43 32 AM

@devoncarew devoncarew requested review from parlough and johnpryan and removed request for parlough August 27, 2024 18:47
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/dartpad_ui/lib/embed.dart
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/default_dart.dart
pkgs/samples/lib/default_flutter.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart
pkgs/samples/tool/samples.dart
Package publish validation ✔️
Package Version Status

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@johnpryan johnpryan merged commit 8eb721a into main Aug 27, 2024
12 checks passed
@johnpryan johnpryan deleted the docs branch August 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants