-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open in IDX feature #2995
Add Open in IDX feature #2995
Conversation
For the UI:
|
I wonder if the 'Install SDK' menu item should move from the continue in menu to the tripple dot overflow menu? It's a different type of action than the IDX one; it doesn't use any of the content of the current snippet. fwiw, I do like having a 'continue in' menu to hold the IDX item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about the menu presentation, and about how we're forming the http POST.
This indicates that pressing the button will take you somewhere (at least that's how I interpret it). When I add this, it looks odd to me:
I'm not familiar with this pattern, to me it would be weird to have two sets of elipses, "Open in... -> IDX... Install SDK..."
Right now we struggle with maintaining so many menu buttons. (For the mobile layout we need hide this button, for example). I'd rather group these together. If there's a dropdown with only one option, that doesn't really add much value to the UI, since it could have just been a button in the first place. |
Awesome that this is live!! @johnpryan one quick note, I noticed the "Flame game" sample doesn't work as-is because the |
Thanks for finding that @romannurik, we should be able to fix this. I filed an issue to track: #3005 |
This adds an API endpoint and UI component to open the current snippet in IDX under the new "Continue in" dropdown.
closes #2984