Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow DartPad injection from window.parent #2993

Closed
wants to merge 17 commits into from
Closed

Only allow DartPad injection from window.parent #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a1da878
Update embed.dart
NDevTK Jun 11, 2024
657ae86
Merge branch 'dart-lang:main' into patch-1
NDevTK Jun 11, 2024
1deaad5
Update embed.dart
NDevTK Jun 11, 2024
d1a0ea8
Verify sender of log message
NDevTK Jun 11, 2024
940f7b2
Same window
NDevTK Jun 11, 2024
e9aaa83
Update frame.dart
NDevTK Jun 11, 2024
b1244a0
Update frame.dart
NDevTK Jun 11, 2024
49e264a
Update frame.dart
NDevTK Jun 12, 2024
cbb7b33
its not going to work
NDevTK Jun 12, 2024
790eb08
Update frame.dart
NDevTK Jun 12, 2024
12bf918
Update frame.dart
NDevTK Jun 12, 2024
552d280
Update frame.dart
NDevTK Jun 12, 2024
3764ba6
Update frame.dart
NDevTK Jun 12, 2024
0c3ca21
put web at the start for no reason and hope it works
NDevTK Jun 12, 2024
adc5399
Update frame.dart
NDevTK Jun 12, 2024
fedbb6c
Update frame.dart
NDevTK Jun 12, 2024
67f1cec
Update frame.dart
NDevTK Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/dartpad_ui/lib/embed.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ void handleEmbedMessage(AppModel model) {
web.window.addEventListener(
'message',
(web.MessageEvent event) {
if (event.source != web.window.parent) return;
if (event.data case _SourceCodeMessage(:final type?, :final sourceCode?)
when type == 'sourceCode') {
if (sourceCode.isNotEmpty) {
Expand Down
3 changes: 3 additions & 0 deletions pkgs/dartpad_ui/lib/execution/frame.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@ require(["dartpad_main", "dart_sdk"], function(dartpad_main, dart_sdk) {
if (data['sender'] != 'frame') {
return;
}
if (event.source == null || _frame.contentWindow != event.source) {
return;
}
final type = data['type'] as String?;

if (type == 'stderr') {
Expand Down