Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lints for v3 releases #2688

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Update lints for v3 releases #2688

merged 4 commits into from
Oct 22, 2023

Conversation

parlough
Copy link
Member

Also standardizes lints a bit closer between the projects.

@parlough parlough marked this pull request as ready for review October 22, 2023 16:42
devoncarew
devoncarew approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I'd consider keeping the pkgs/samples/analysis_options.yaml file pretty close to the stock one from flutter_lints.

.github/workflows/samples.yml Outdated Show resolved Hide resolved
pkgs/samples/analysis_options.yaml Outdated Show resolved Hide resolved
@parlough parlough merged commit 55029b7 into dart-lang:main Oct 22, 2023
10 checks passed
@parlough parlough deleted the misc/flutter-lints-3-0 branch October 22, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parlough @devoncarew