switch 'serverRevision' to use the build short SHA (#2776)

dart-lang · Dec 28, 2023 · 51a964c · 51a964c
1 parent 1f70b2c
commit 51a964c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/.cloud_build/dart_services.yaml b/.cloud_build/dart_services.yaml
@@ -73,6 +73,8 @@ steps:
       - PROJECT_ID=$PROJECT_ID
       - --build-arg
       - FLUTTER_CHANNEL=${_FLUTTER_CHANNEL}
+      - --build-arg
+      - BUILD_SHA=${SHORT_SHA}
       - .
     dir: pkgs/dart_services
 

diff --git a/pkgs/dart_services/Dockerfile b/pkgs/dart_services/Dockerfile
@@ -1,5 +1,7 @@
 ARG PROJECT_ID
 ARG FLUTTER_CHANNEL
+ARG BUILD_SHA
+
 FROM gcr.io/$PROJECT_ID/flutter:$FLUTTER_CHANNEL
 
 WORKDIR /app

diff --git a/pkgs/dart_services/lib/src/common_server.dart b/pkgs/dart_services/lib/src/common_server.dart
@@ -242,7 +242,7 @@ class CommonServerApi {
       dartVersion: sdk.dartVersion,
       flutterVersion: sdk.flutterVersion,
       engineVersion: sdk.engineVersion,
-      serverRevision: Platform.environment['K_REVISION'],
+      serverRevision: Platform.environment['BUILD_SHA'],
       experiments: sdk.experiments,
       packages: packages,
     );