allow 3.6.x sdks #3724
Merged
allow 3.6.x sdks #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Jul 1, 2024
| description: >- | ||
| Builders to analyze and split Dart code into individually compilable modules | ||
| based on imports. | ||
| repository: https://github.com/dart-lang/build/tree/master/build_modules | ||
| resolution: workspace | ||
|
|
||
| environment: | ||
| sdk: '>=3.5.0-259.0.dev <3.6.0' | ||
| sdk: '>=3.5.0-259.0.dev <3.7.0' |
There was a problem hiding this comment.
Is there any reason not to change the lower bound to >=3.5.0?
There was a problem hiding this comment.
Well, 3.5 isn't actually out yet.
There was a problem hiding this comment.
At a minimum our "pubspec" SDK jobs would fail.
There was a problem hiding this comment.
Ah, surprising that we're prepping for 3.6 without launching 3.5...
LGTM.
There was a problem hiding this comment.
Yeah it happens when we cut the branch that will be 3.5 stable. That way we don't have misleading -dev tags that make people put in bad constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblock the version bump in the SDK