log error stack #3630
Closed
log error stack #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
natebosch
commented
Dec 27, 2023
natebosch
commented
- Always log stack traces for Error objects
- Fix json serializable annotation for ignored field
Closes #3585 The default logging omits stack traces by default and prints them only in verbose mode. This is intended to allow builder implementations to cease execution and log a user friendly message by throwing a single `Exception` with a custom `toString()`. When a builder or utility library has an implementation bug leading to an `Error` the stack trace is much more likely to be useful information for debugging, and worth including by default.
The annotation was last changed in #3445 The intention of the change was to retain behavior of passing the deprecated option `ignore: true`. The replacement is to use two fields `includeToJson` and `includeFromJson` which allow more fine-grained configuration, but also invert the condition. The boolean must be `false` to retain old behavior. Before this change rerunning code generation would result in a change to `build_config.g.gdart`. After this change the build is a no-op.
|
I was not on a sensible branch when I opened this... I'l try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.