Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify the analyzer of deleted files #3584

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Notify the analyzer of deleted files #3584

merged 2 commits into from
Sep 28, 2023

Conversation

jakemac53
Copy link
Contributor

Related to dart-lang/source_gen#682.

Deleted files were never getting a changeFile call and so they were still available in the analyzer. This exposed in particular old generated part files to subsequent builds which could cause weird errors.

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:build_runner 2.4.7-dev ready to publish build_runner-v2.4.7-dev
package:build_config 1.1.2-dev ready to publish build_config-v1.1.2-dev
package:build_daemon 4.0.1-dev ready to publish build_daemon-v4.0.1-dev
package:build_runner_core 7.2.11 already published at pub.dev
package:build_web_compilers 4.0.5 already published at pub.dev
package:build_modules 5.0.4 already published at pub.dev
package:build_resolvers 2.4.1-wip WIP (no publish necessary)
package:build_test 2.2.1 already published at pub.dev
package:scratch_space 1.0.2 already published at pub.dev
package:build 2.4.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@jakemac53 jakemac53 merged commit e2c837b into master Sep 28, 2023
70 checks passed
@jakemac53 jakemac53 deleted the resolver-fix branch September 28, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants