Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip delete for SDK summary and deps file #3573

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

natebosch
Copy link
Member

Fixes #2995

When the summary file is determined to be invalid, regenerate it and
overwrite it without deleting. This resolves a race condition where
multiple resolvers could try to delete the same file. The invalid
content will not be read, because we will regenerate the file before
moving on to the rest of the build.

Fixes #2995

When the summary file is determined to be invalid, regenerate it and
overwrite it without deleting. This resolves a race condition where
multiple resolvers could try to delete the same file. The invalid
content will not be read, because we will regenerate the file before
moving on to the rest of the build.
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:build_resolvers 2.3.2 ready to publish build_resolvers-v2.3.2
package:build_daemon 4.0.1-dev pre-release version (no publish necessary)
package:scratch_space 1.0.2 already published at pub.dev
package:build 2.4.1 already published at pub.dev
package:build_config 1.1.2-dev pre-release version (no publish necessary)
package:build_modules 5.0.4 already published at pub.dev
package:build_web_compilers 4.0.5 already published at pub.dev
package:build_runner_core 7.2.11-dev pre-release version (no publish necessary)
package:build_runner 2.4.7-dev pre-release version (no publish necessary)
package:build_test 2.2.1-dev pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@natebosch natebosch merged commit a161297 into master Sep 6, 2023
70 checks passed
@natebosch natebosch deleted the no-delete-sdk-summary branch September 6, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition initializing AnalyzerResolvers
2 participants