don\'t require a local package config in watch mode

dart-lang · Jun 17, 2024 · 4c3c7e9 · 4c3c7e9
1 parent bd793f5
commit 4c3c7e9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/_test/test/common/utils.dart b/_test/test/common/utils.dart
@@ -36,8 +36,7 @@ Future<void> startServer(
     _startServer(
       'dart',
       [
-        '--packages=',
-        (await Isolate.packageConfig).toString(),
+        '--packages=${(await Isolate.packageConfig).toString()}',
         p.join('..', 'build_runner', 'bin', 'build_runner.dart'),
         'serve',
         '--verbose',

diff --git a/build_runner/lib/src/generate/watch_impl.dart b/build_runner/lib/src/generate/watch_impl.dart
@@ -332,8 +332,14 @@ class WatchImpl implements BuildState {
     () async {
       await logTimedAsync(_logger, 'Waiting for all file watchers to be ready',
           () => graphWatcher.ready);
-      originalRootPackageConfigDigest = md5.convert(
-          await watcherEnvironment.reader.readAsBytes(rootPackageConfigId));
+      if (await watcherEnvironment.reader.canRead(rootPackageConfigId)) {
+        originalRootPackageConfigDigest = md5.convert(
+            await watcherEnvironment.reader.readAsBytes(rootPackageConfigId));
+      } else {
+        _logger.warning(
+            'Root package config not readable, manual restarts will be needed '
+            'after running `pub upgrade`.');
+      }
 
       BuildResult firstBuild;
       BuildImpl? build;