Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null safety upgrade #14

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

jcramer
Copy link
Contributor

@jcramer jcramer commented Apr 24, 2021

Just wanted to help moving things along for this. I know there is another PR for null safety but there are conflicts and it may be getting stale. I did a quick upgrade from master and checked the tests are still passing.

It looks like vscode dart plugin thinks lines were getting too long, so it automatically did some linting to multi-lines in some cases. If this is undesirable, lmk and I'll try to revert it.

On a separate note, I noticed travis build hasn't been setup for this repo. Would be as simple as adding .travis.yml file with just language: dart.

@p3root p3root merged commit 779149a into dart-bitcoin:master May 27, 2021
@SFzxc
Copy link
Contributor

SFzxc commented May 28, 2021

Thanks @jcramer. Would you mind to become maintainer of https://github.com/dart-bitcoin/bitcoin_flutter

@SFzxc
Copy link
Contributor

SFzxc commented May 28, 2021

This cool PR is pre-step to resolved dart-bitcoin/bitcoin_flutter#50. let me know if you're interesting, Thank for your contributing!

@p3root
Copy link
Collaborator

p3root commented May 28, 2021

@SFzxc will look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants